Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suite connector integration test #44

Closed
nzhechev-bosch opened this issue Aug 29, 2022 · 1 comment · Fixed by #45
Closed

Add suite connector integration test #44

nzhechev-bosch opened this issue Aug 29, 2022 · 1 comment · Fixed by #45
Assignees
@dimiter-todorov-georgiev
Labels
task Single unit of work
Milestone
M3

Comments

@nzhechev-bosch
Copy link
Contributor

At minimum, the test should cover:

  • subscription forwarding, i.e. device status check
  • message forwarding for the following Ditto message types:
    • telemetry
    • events
    • command and responses
nzhechev-bosch added a commit to bosch-io/suite-connector that referenced this issue Aug 29, 2022
@nzhechev-bosch
[eclipse-kanto#44] Added suite connector integration test
59af87f 
Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
nzhechev-bosch added a commit to bosch-io/suite-connector that referenced this issue Aug 29, 2022
@nzhechev-bosch
[eclipse-kanto#44] Fixed golint errors
d4a6470 
Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
@konstantina-gramatova konstantina-gramatova linked a pull request Sep 10, 2022 that will close this issue
Added suite connector integration test #45
Merged
@konstantina-gramatova konstantina-gramatova added the task Single unit of work label Sep 10, 2022
@konstantina-gramatova konstantina-gramatova added this to the M2 milestone Sep 10, 2022
nzhechev-bosch added a commit to bosch-io/suite-connector that referenced this issue Sep 13, 2022
@nzhechev-bosch
[eclipse-kanto#44] Added delta to readySince/Until validity checks
e301149 
Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
nzhechev-bosch added a commit to bosch-io/suite-connector that referenced this issue Sep 14, 2022
@nzhechev-bosch
[eclipse-kanto#44] Fixed time delta config property name
a5ecc0f 
Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
@e-grigorov e-grigorov mentioned this issue Sep 14, 2022
Merged
nzhechev-bosch added a commit to bosch-io/suite-connector that referenced this issue Sep 16, 2022
@nzhechev-bosch
[eclipse-kanto#44] Replaced Ditto host/port config properties with si…
acdb72b 
…ngle address property

Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
nzhechev-bosch added a commit to bosch-io/suite-connector that referenced this issue Sep 19, 2022
@nzhechev-bosch
[eclipse-kanto#44] Minor adjustments, based on PR comments:
9ba02b0 
New Eclipse Kanto license header used
Renamed featureName to featureID
StatusOK used for command response
readyUntil now expected to be "9999-12-31T23:59:59Z"

Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
nzhechev-bosch added a commit to bosch-io/suite-connector that referenced this issue Sep 20, 2022
@nzhechev-bosch
[eclipse-kanto#44] Now the test waits some time for the connection st…
9b29032 
…atus to be updated

Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
nzhechev-bosch added a commit to bosch-io/suite-connector that referenced this issue Sep 20, 2022
@nzhechev-bosch
[eclipse-kanto#44] Status timeout name fixed
c2e5013 
Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
@konstantina-gramatova konstantina-gramatova modified the milestones: M2, M3 Sep 27, 2022
Open
nzhechev-bosch added a commit to bosch-io/suite-connector that referenced this issue Oct 10, 2022
@nzhechev-bosch
[eclipse-kanto#44] Requre no error on websocket connect
88eb96a 
Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
dimiter-todorov-georgiev pushed a commit to bosch-io/suite-connector that referenced this issue Oct 25, 2022
[eclipse-kanto#44] Require no error on setting up the test
be6a059 
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
dimiter-todorov-georgiev pushed a commit to bosch-io/suite-connector that referenced this issue Oct 25, 2022
@nzhechev-bosch
[eclipse-kanto#44] Added suite connector integration test
0032620 
Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
dimiter-todorov-georgiev pushed a commit to bosch-io/suite-connector that referenced this issue Oct 25, 2022
@nzhechev-bosch
[eclipse-kanto#44] Fixed golint errors
d43a7c7 
Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
dimiter-todorov-georgiev pushed a commit to bosch-io/suite-connector that referenced this issue Oct 25, 2022
@nzhechev-bosch
[eclipse-kanto#44] Added delta to readySince/Until validity checks
2c9d5d0 
Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
dimiter-todorov-georgiev pushed a commit to bosch-io/suite-connector that referenced this issue Oct 25, 2022
@nzhechev-bosch
[eclipse-kanto#44] Fixed time delta config property name
0d2ea3a 
Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
dimiter-todorov-georgiev pushed a commit to bosch-io/suite-connector that referenced this issue Oct 25, 2022
@nzhechev-bosch
[eclipse-kanto#44] Replaced Ditto host/port config properties with si…
2c10217 
…ngle address property

Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
dimiter-todorov-georgiev pushed a commit to bosch-io/suite-connector that referenced this issue Oct 25, 2022
@nzhechev-bosch
[eclipse-kanto#44] Minor adjustments, based on PR comments:
9a95295 
New Eclipse Kanto license header used
Renamed featureName to featureID
StatusOK used for command response
readyUntil now expected to be "9999-12-31T23:59:59Z"

Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
dimiter-todorov-georgiev pushed a commit to bosch-io/suite-connector that referenced this issue Oct 25, 2022
@nzhechev-bosch
[eclipse-kanto#44] Now the test waits some time for the connection st…
0b31839 
…atus to be updated

Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
dimiter-todorov-georgiev pushed a commit to bosch-io/suite-connector that referenced this issue Oct 25, 2022
@nzhechev-bosch
[eclipse-kanto#44] Status timeout name fixed
ddaa17a 
Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
dimiter-todorov-georgiev pushed a commit to bosch-io/suite-connector that referenced this issue Oct 25, 2022
@nzhechev-bosch
[eclipse-kanto#44] Requre no error on websocket connect
4cab5c0 
Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
dimiter-todorov-georgiev pushed a commit to bosch-io/suite-connector that referenced this issue Oct 25, 2022
[eclipse-kanto#44] Require no error on setting up the test
62a270d 
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
dimiter-todorov-georgiev pushed a commit to bosch-io/suite-connector that referenced this issue Oct 25, 2022
[eclipse-kanto#44] Do not use a prefix for env variables
e83ea14 
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
dimiter-todorov-georgiev pushed a commit to bosch-io/suite-connector that referenced this issue Oct 25, 2022
[eclipse-kanto#44] Address PR feedback - use default HTTPS and HTTP p…
dfc3de9 
…orts if missing

Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] The build tag e2einttest is now replaced by integr…
29d9520 
…ation

Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Changes to environment variables according to feed…
065002f 
…back

- Rename Hono environment variables to DeviceRegistryApi
- Rename Ditto environment variables to DigitalTwinApi
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Code changes due to PR feedback
555b4ce 
- Renamed mqtt package import to MQTT
- Removed unneeded call to .Fail()
- Properly failing the test when responses are unable to be sent to the backend
- Refactored getPortOrDefault()
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Integration test bugix
fa1cf67 
- Fix error handling when receiving an unknown command. This can happen for reasons which are unrelated to this test, so instead of failign the test, log the unrecognized command and continue the test.
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Changes due to PR comments
db0138c 
- Use the Ditto library where appropriate, removing custom structs
- Use constructors where required
- Use proper error messages with require.NoError() where they were missing
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Fix golint issues
d2d7d0b 
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Remove an accidentally added file
6b4c305 
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Remove asynchronous test failures, move them to th…
1a5439f 
…e test goroutine

Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Address code review feedback
8c1ebac 
- Use 0 as default offset when comparing connection status' readySince to now
- Added a sleep time between attempts to read connection status, defaulting to 2 seconds
- Changed command test code to properly use the Message struct from the ditto library
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Add a missing return statement
63c2451 
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Fix a golint issue: remove the new lines at the en…
b4da575 
…d of errors

Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Refactor beginWSWait in preparation for the common…
8124d0b 
… integration test code

Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Fix issues in ProcessMessages and rename to Proces…
890ce25 
…sWSMessages

Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Remove the Subscribe and WaitSubscribeResult funct…
3695e7a 
…ions

Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Unsubscribe from local MQTT events on getThingConf…
9f61224 
…ig()

Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Consistently use MillisToDuration() and switch to …
75b9706 
…64-bit math to avoid overflow

Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Use the common integration test repository
8239bc6 
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Remove redundant log messages
00ce6ab 
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Use embedding for SuiteInitializer
04e0410 
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Use a common code function call
dd0cc5a 
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Address code review feedback
be2ac4e 
- Switch to using the Digital Twin REST API for sending a command to the feature
- Minor fixes
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Code cleanup
bf2c229 
- Removed unneeded lines
- Use the DITTO API for checking of the expected topic
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Refactored code to use the new common integration …
d4441fe 
…test logic

- Removed variables which come from the common code
- Use the new API functions provided by the common logic
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Removed debug prints
52b0a30 
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Use util.GetTwinEventTopic
74296b6 
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Addressing PR feedback:
6ea6f00 
- Update NOTICE.md with the updated version of the uuid library.
- Remove the extra check (and relevant code) for sending an answer to an operation message.
- Use the util function ExecuteOperation.
- Compare time.Time using time.Equal.
- Fix the initialization of the variable now.
- Move the initialization of a variable closer to where it's used, reducing its scope.
- Stop using GetFeatureOutboxMessagePath to obtain the inbox.
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Use the new utility functions GetFeaturePropertyVa…
250d4f9 
…lue and GetFeatureInboxMessagePath.

Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit to bosch-io/suite-connector that referenced this issue Nov 25, 2022
@e-grigorov
[eclipse-kanto#44] Remove an unused environment variable.
925fa2b 
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
e-grigorov pushed a commit that referenced this issue Nov 25, 2022
@nzhechev-bosch
Added suite connector integration test (#45)
8379f6b 
[#44] Added suite connector integration test

Signed-off-by: Nikola Zhechev <Nikola.Zhechev@bosch.io>
Signed-off-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
Co-authored-by: Dimiter Georgiev <dimiter.georgiev@bosch.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimiter-todorov-georgiev dimiter-todorov-georgiev

Labels
task Single unit of work
Projects
Eclipse Kanto
Status: Done
Milestone
M3
Development

Successfully merging a pull request may close this issue.

Added suite connector integration test bosch-io/suite-connector
3 participants
@nzhechev-bosch @konstantina-gramatova @dimiter-todorov-georgiev