Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orchestration apply and feedback unit tests #30

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Orchestration apply and feedback unit tests #30

merged 2 commits into from
Jul 31, 2023

Conversation

apetrovv
Copy link
Contributor

[#29] Add unit tests for orchestration feedback and apply

@k-gostev k-gostev self-requested a review July 31, 2023 12:29
k-gostev
k-gostev suggested changes Jul 31, 2023
View reviewed changes
Copy link
Member

@k-gostev k-gostev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Overall looks very good, I just have a couple of nits that I would like to be fixed

updatem/orchestration/update_orchestrator_apply_test.go Outdated Show resolved Hide resolved
updatem/orchestration/update_orchestrator_apply_test.go Outdated Show resolved Hide resolved
updatem/orchestration/update_orchestrator_apply_test.go Outdated Show resolved Hide resolved
updatem/orchestration/update_orchestrator_apply_test.go Outdated Show resolved Hide resolved
updatem/orchestration/update_orchestrator_apply_test.go Outdated Show resolved Hide resolved
updatem/orchestration/update_orchestrator_apply_test.go Outdated Show resolved Hide resolved
updatem/orchestration/update_orchestrator_apply_test.go Outdated Show resolved Hide resolved
updatem/orchestration/update_orchestrator_feedback_test.go Outdated Show resolved Hide resolved
updatem/orchestration/update_orchestrator_feedback_test.go Show resolved Hide resolved
@k-gostev k-gostev linked an issue Jul 31, 2023 that may be closed by this pull request
Add unit tests for orchestration feedback and apply #29
Closed
@k-gostev k-gostev merged commit 6a8a1bb into eclipse-kanto:main Jul 31, 2023
1 check passed
@apetrovv apetrovv deleted the orchestration-aplly-feedback-unit-tests branch July 31, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-gostev k-gostev k-gostev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit tests for orchestration feedback and apply
2 participants
@apetrovv @k-gostev