Remove Mutual Authentication (Fixing KUKSA Server token handling) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbosch
force-pushed
the
erik_release
branch
2 times, most recently
from
93dd2d7
to
ef5cf21
Compare
erikbosch
changed the title
erikbosch
commented
May 10, 2024
| @@ -297,8 +297,6 @@ async def connect(self, _=None): | |||
| subprotocols = ["VISSv2"] | |||
| if not self.insecure: | |||
| context = ssl.create_default_context() | |||
| context.load_cert_chain( | |||
| certfile=self.certificate, keyfile=self.keyfile) | |||
There was a problem hiding this comment.
If we do not want to remove support for client auth then this statement must be modified by checking that both are not null before calling it
erikbosch
changed the title
|
@SebastianSchildt - I noticed a side effect for ws/server connection after removing default certs/tokens, instead of adapting I think this could be a good time to remove client key/cert handling, as we anyway do not support it in Server or databroker, and do not plan to support it. |
erikbosch
force-pushed
the
erik_release
branch
2 times, most recently
from
8e3d770
to
f66aadb
Compare
erikbosch
commented
May 13, 2024
| @@ -35,6 +35,7 @@ jobs: | |||
| > dependencies.txt | |||
|
|
|||
| - name: Dash license check | |||
| uses: eclipse-kuksa/kuksa-actions/check-dash@2 | |||
| uses: eclipse-kuksa/kuksa-actions/check-dash@4 | |||
There was a problem hiding this comment.
Trying out the dash update as well @SebastianSchildt
Not actively supported anyway and current handling for ws did not work after removing default certs
SebastianSchildt
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #23. Previously we always had default client key/certs and fed them to KUKSA Server unless some other key/cert was given. So in short, they were never null or empty string. Now they might be empty unless specified in config or similar, so we must handle that scenario. But opting for removing client key support instead.