Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unactionable warnings when a plugin is ignored by m2e #1298

Closed
vtintillier opened this issue Mar 4, 2023 Discussed in #1229 · 0 comments · Fixed by #1299
Closed

Remove unactionable warnings when a plugin is ignored by m2e #1298

vtintillier opened this issue Mar 4, 2023 Discussed in #1229 · 0 comments · Fixed by #1299

Comments

@vtintillier
Copy link
Contributor

Discussed in #1229

Especially @kwin and @laeubi agreed on this proposal to avoid those useless warnings:

I think the message part inside the ignore lets m2e emit that warning. I don't think this warning is useful but rather confusing therefore I propose to remove all message lines from

<message>maven-enforcer-plugin (goal "enforce") is ignored by m2e.</message>

Originally posted by vtintillier February 2, 2023
Hello,

I am not sure if the behavior I see is intended or not.

maven-enforcer-plugin removed their META-INF/m2e/lifecycle-mapping-metadata.xml file in their last 3.2.1 release (apache/maven-enforcer#192). As a result, we see this warning in all our poms:

maven-enforcer-plugin (goal "enforce") is ignored by m2e

image

It seems this messages originate from this code:

<pluginExecution>
<pluginExecutionFilter>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<goals>
<goal>enforce</goal>
</goals>
<versionRange>[1.0-alpha-1,)</versionRange>
</pluginExecutionFilter>
<action>
<ignore>
<message>maven-enforcer-plugin (goal "enforce") is ignored by m2e.</message>
</ignore>
</action>
</pluginExecution>

So my question is: is this expected that goals ignored in m2e-core own lifecycle-mapping-metadata.xml appear as warnings in the editor, whereas goals ignored in maven plugins own lifecycle-mapping-metadata.xml do not?
Also is there a way to disable those warnings?

Thanks
Vivien

vtintillier added a commit to vtintillier/m2e-core that referenced this issue Mar 4, 2023
vtintillier added a commit to vtintillier/m2e-core that referenced this issue Mar 5, 2023
laeubi pushed a commit that referenced this issue Mar 6, 2023
* Remove unactionable warnings when a plugin is ignored

Fixes #1298

* Bump org.eclipse.m2e.core micro version

* align pom version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant