Modify the implementation of isUnnamedClass() #17766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #17725 (comment) Both |
|
PR to re-enable excluded tests adoptium/aqa-tests#4664 |
Unfortunately my comment has been ignored, the aqa-tests PR is merged. |
|
Pls set it as a draft in the future. |
+1 - we have a few reviewers in that repo that do not honour those type of requests, so best to keep in draft until dependent issues resolved. |
keithc-ca
reviewed
Jul 11, 2023
Change the order of the checks to do modifier check first Closes eclipse-openj9#17725 Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
keithc-ca
approved these changes
Jul 11, 2023
|
jenkins test sanity alinux64 jdk21 |
tajila
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the order of the checks to do modifier check first
Closes #17725