Implement JEP 451: Prepare to Disallow the Dynamic Loading of Agents #17932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Aug 10, 2023
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/DiagnosticUtils.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/DiagnosticUtils.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/DiagnosticUtils.java
Outdated
Show resolved
Hide resolved
pshipton
reviewed
Aug 11, 2023
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/DiagnosticUtils.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/DiagnosticUtils.java
Outdated
Show resolved
Hide resolved
|
The line endings check failed. |
|
The JEP is for jdk21 but many of the changes to OpenJ9 apply to all versions so I've removed the jdk21 label. |
|
There hasn't been any doc issue created for |
Only JDK21 prints the warning message. |
keithc-ca
requested changes
Aug 11, 2023
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/DiagnosticUtils.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/DiagnosticUtils.java
Show resolved
Hide resolved
keithc-ca
requested changes
Aug 11, 2023
keithc-ca
requested changes
Aug 11, 2023
Print warning message when loading an agent via AttachAPI loadAgentLibraryImpl() if -XX:+EnableDynamicAgentLoading is not specified, and the agent wasn't loaded before; Added isAgentLibraryLoaded() to determine if an agent has been loaded already; Implemented JVM_PrintWarningAtDynamicAgentLoad(); Added jcmd command JVMTI.agent_load; Updated a few trace points within loadAgentLibraryGeneric(). Signed-off-by: Jason Feng <fengj@ca.ibm.com>
|
Jenkins test sanity aix,zlinux,win jdk17 |
keithc-ca
approved these changes
Aug 12, 2023
Created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement JEP 451: Prepare to Disallow the Dynamic Loading of Agents
Print warning message when loading an agent via
AttachAPIloadAgentLibraryImpl()if-XX:+EnableDynamicAgentLoadingis not specified, and the agent wasn't loaded before;Added
isAgentLibraryLoaded()to determine if an agent has been loaded already;Implemented
JVM_PrintWarningAtDynamicAgentLoad();Added
jcmdcommandJVMTI.agent_loadto support openjdk testtest/jdk/com/sun/tools/attach/warnings/DynamicLoadWarningTest.java;Updated a few trace points within
loadAgentLibraryGeneric().This passes an internal grinder
openjdktest/jdk/com/sun/tools/attach/warnings/DynamicLoadWarningTest.javaw/related
Signed-off-by: Jason Feng fengj@ca.ibm.com