Remove CFR_ACC_VALUE_TYPE and CFR_ACC_PRIMITIVE_VALUE_TYPE #19631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
added
comp:vm
project:valhalla
hangshao0
reviewed
Jun 5, 2024
|
The line ending check failed. |
hangshao0
reviewed
Jun 5, 2024
hangshao0
reviewed
Jun 6, 2024
hangshao0
reviewed
Jun 7, 2024
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
|
Jenkins compile zlinuxval jdknext |
|
Jenkins compile amac jdknext |
hangshao0
approved these changes
Jun 7, 2024
keithc-ca
reviewed
Jun 7, 2024
| @@ -3140,19 +3140,10 @@ j9bcutil_readClassFileBytes(J9PortLibrary *portLib, | |||
|
|
|||
| #if defined(J9VM_OPT_VALHALLA_VALUE_TYPES) | |||
| /* Currently value type is built on JDK22, so compare with JDK22 for now. */ | |||
There was a problem hiding this comment.
This comment should have been updated with the change on line 3143.
There was a problem hiding this comment.
Thanks Keith. I have another pull request in the works to close out #18829 I will update the comment there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.