Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate runtime NULL test for Unsafe.compareAndSwap() #20163

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

midronij
Copy link
Contributor

Add a NULL test to the sequence of runtime tests performed before calling Unsafe.compareAndSwap() to ensure that when offheap is enabled, we don't try to load dataAddr from a NULL reference.

@midronij
Copy link
Contributor Author

midronij commented Sep 13, 2024

@rmnattas @zl-wang Unsafe.CAS() fix is done!

Add a NULL test to the sequence of runtime tests performed before
calling Unsafe.compareAndSwap() to ensure that when offheap is enabled,
we don't try to load dataAddr from a NULL reference.

Signed-off-by: midronij <jackie.midroni@ibm.com>
Copy link
Contributor

@zl-wang zl-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zl-wang
Copy link
Contributor

zl-wang commented Sep 16, 2024

jenkins test sanity plinux,xlinux,zlinux jdk8

@zl-wang
Copy link
Contributor

zl-wang commented Sep 16, 2024

ignore xlinux infra issue ... merging

@zl-wang zl-wang merged commit 0985ff3 into eclipse-openj9:master Sep 16, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants