Remove flattening flag from nullable arrays

[theresa-m]

Update ValueTypeUnsafeTests tests to use flattenable array.
Update ValueTypeSystemArraycopyTests to test System.arrayCopy
between nullable and null-restricted arrays.

Fixes: #20223
Fixes: #20253

[theresa-m]

@a7ehuo can you review the tests on this change?

[a7ehuo]

The test update looks good to me. Thank you very much for the change @theresa-m!

[hangshao0]

@a7ehuo can you review the tests on this change?

There are some new changes to the test, could you review again ? @a7ehuo

[a7ehuo]

Thank you very much for the update! Sorry I just realized I missed a few things in my first review. They are minor comments

[a7ehuo]

nullRestrictedVtArrayDst[i] and nullRestrictedVtArraySrc[i] are now being initialized twice: line 124/125 and line 140/141. I think only one set of initialization is required

[a7ehuo]

To properly test the interpreter and the JIT, these two lines need to run twice since a lot of JIT options include count=1. Running it once won't get testVTVT method compiled. And the result should be checked to make sure the array element data is copied correctly.

Maybe something like below

	@Test(priority=1)
	static public void testSystemArrayCopy27() throws Throwable {
		initArrays();
		testVTVT(vtArraySrc, nullRestrictedVtArrayDst);
		checkResults(vtArraySrc, nullRestrictedVtArrayDst);

		initArrays();
		testVTVT(vtArraySrc, nullRestrictedVtArrayDst);
		checkResults(vtArraySrc, nullRestrictedVtArrayDst);
	}

[hzongaro]

Or use the attribute @Test(priority=1,invocationCount=2), if the test has the -Xjit:count=1,disableAsyncCompilation option specified.

[a7ehuo]

Same comments as the above

	@Test(priority=1)
	static public void testSystemArrayCopy28() throws Throwable {
		initArrays();
		testVTVT(nullRestrictedVtArraySrc, vtArrayDst);
		checkResults(nullRestrictedVtArraySrc, vtArrayDst);

		initArrays();
		testVTVT(nullRestrictedVtArraySrc, vtArrayDst);
		checkResults(nullRestrictedVtArraySrc, vtArrayDst);
	}

[a7ehuo]

To properly test the interpreter and the JIT, these two lines need to run twice. Maybe something like below

	@Test(priority=1)
	static public void testSystemArrayCopy29() throws Throwable {
		try { 
		   initArraysToCopyNullToNullRestrictedArray();
		   testVTVT(vtArraySrc, nullRestrictedVtArrayDst); // First time invoke the interpreter
		} catch (java.lang.ArrayStoreException ase1) {
			try {
		      initArraysToCopyNullToNullRestrictedArray();
		      testVTVT(vtArraySrc, nullRestrictedVtArrayDst); // Second time JIT'd method 
			} catch (java.lang.ArrayStoreException ase2) {
				// pass
				return;
			}
		}

		Assert.fail("Expect a ArrayStoreException. No exception or wrong kind of exception thrown");
	}

[hzongaro]

Or we sometimes adjust the @Test attribute to run the test method twice, so methods will be compiled the second time if the test is accompanied by the -Xjit:count=1,disableAsyncCompilation option.

@Test(priority=1,invocationCount=2)

[a7ehuo]

Could you use Henry's suggestion, #20250 (comment) instead of copying/paste the code twice like I initially suggested?

[a7ehuo]

Same comment applies to testSystemArrayCopy28 and testSystemArrayCopy29 as well

[a7ehuo]

LGTM. Thanks for the update on the test file!

[hangshao0]

Jenkins test sanity,extended zlinuxval jdknext

[hangshao0]

Jenkins compile amac jdk23

[hangshao0]

The sanity.openjdk failure is not related to this change.