Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary casting #20317

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

theresa-m
Copy link
Contributor

Related to #20290 (review)

Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@theresa-m theresa-m added comp:vm project:valhalla Used to track Project Valhalla related work labels Oct 8, 2024
@keithc-ca keithc-ca self-assigned this Oct 8, 2024
@keithc-ca
Copy link
Contributor

Jenkins test sanity.functional alinuxval jdknext

Copy link
Contributor

@keithc-ca keithc-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While reviewing this, I noticed several array declarations that until recently I would have thought just elicit compile errors. For example, the C-style declaration on line 265:

		String fields[] = {"x:I", "y:I"};

should put the brackets with the type:

		String[] fields = {"x:I", "y:I"};

When you get a chance, perhaps you could tidy up things like that too. Thanks.

@keithc-ca keithc-ca merged commit 70f99fd into eclipse-openj9:master Oct 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants