Bug 516583 - Use UTF-8 as default encoding for *new* workspaces #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set UTF-8 foor new workspace as default workspace encoding if Eclipse is started without explicit encoding set (either as JVM system property -Dfile.encoding=XYZ or by product customization preference org.eclipse.core.resources/encoding=XYZ). After that all projects created in this workspace will get explicit UTF-8 encoding set (they will derive that from the workspace encoding and not from some random encoding taken from current OS settings). Existing workspaces or projects with explicit encoding set will be not affected by the change.
|
The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-51/4/ |
iloveeclipse
added a commit
to iloveeclipse/eclipse.jdt.core
that referenced
this pull request
Feb 19, 2023
Original test assumed workspace always uses system default encoding and projects follow that if nothing is set explikcitly. This assumption was not correct anymore after eclipse-platform/eclipse.platform.resources#51 and eclipse-platform/eclipse.platform.resources@961d080 For the concrete test to succeed we should set "system" encoding on the project we use. Fixes eclipse-jdt#462
3 tasks
iloveeclipse
added a commit
to eclipse-jdt/eclipse.jdt.core
that referenced
this pull request
Feb 19, 2023
Original test assumed workspace always uses system default encoding and projects follow that if nothing is set explikcitly. This assumption was not correct anymore after eclipse-platform/eclipse.platform.resources#51 and eclipse-platform/eclipse.platform.resources@961d080 For the concrete test to succeed we should set "system" encoding on the project we use. Fixes #462
vogella
added a commit
to vogellacompany/eclipse.platform
that referenced
this pull request
Jul 3, 2024
eclipse-platform/eclipse.platform.resources#51 implemented logic to set UTF-8 as standard. I suggest to also set the default preference value to UTF-8.
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this pull request
Jul 18, 2024
Original test assumed workspace always uses system default encoding and projects follow that if nothing is set explikcitly. This assumption was not correct anymore after eclipse-platform/eclipse.platform.resources#51 and eclipse-platform/eclipse.platform.resources@961d080 For the concrete test to succeed we should set "system" encoding on the project we use. Fixes eclipse-jdt#462
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set UTF-8 foor new workspace as default workspace encoding if Eclipse is
started without explicit encoding set (either as JVM system property
-Dfile.encoding=XYZ or by product customization preference
org.eclipse.core.resources/encoding=XYZ).
After that all projects created in this workspace will get explicit
UTF-8 encoding set (they will derive that from the workspace encoding
and not from some random encoding taken from current OS settings).
Existing workspaces or projects with explicit encoding set will be not
affected by the change.
This PR requires eclipse-platform/eclipse.platform.runtime#22 merged first