Find/Replace Overlay unused fields #2060
Labels
enhancement
New feature or request
Comments
61 tasks
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this issue
Sep 27, 2024
The tests for the FindReplaceDialog and FindReplaceOverlay currently use reflection to access specific UI elements. This ties the test implementations to implementation details of the production classes (i.e., specific hidden field to be present) and particularly requires the production code to contain (hidden) fields even if they would not be required just to provide according tests. This change replaces the reflective access (at the code level) with widget extraction functionality based on unique information about the widget to be searched for. This may also be considered reflective (at the configuration level), but at least it gets rid of requiring the code to contain specific fields just in order to write tests that need to extract them. Fixes eclipse-platform#2060
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this issue
Sep 27, 2024
The tests for the FindReplaceDialog and FindReplaceOverlay currently use reflection to access specific UI elements. This ties the test implementations to implementation details of the production classes (i.e., specific hidden field to be present) and particularly requires the production code to contain (hidden) fields even if they would not be required just to provide according tests. This change replaces the reflective access (at the code level) with widget extraction functionality based on unique information about the widget to be searched for. This may also be considered reflective (at the configuration level), but at least it gets rid of requiring the code to contain specific fields just in order to write tests that need to extract them. Fixes eclipse-platform#2060
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this issue
Sep 28, 2024
The tests for the FindReplaceDialog and FindReplaceOverlay currently use reflection to access specific UI elements. This ties the test implementations to implementation details of the production classes (i.e., specific hidden field to be present) and particularly requires the production code to contain (hidden) fields even if they would not be required just to provide according tests. This change replaces the reflective access (at the code level) with widget extraction functionality based on unique information about the widget to be searched for. This may also be considered reflective (at the configuration level), but at least it gets rid of requiring the code to contain specific fields just in order to write tests that need to extract them. Fixes eclipse-platform#2060
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this issue
Sep 30, 2024
The tests for the FindReplaceDialog and FindReplaceOverlay currently use reflection to access specific UI elements. This ties the test implementations to implementation details of the production classes (i.e., specific hidden field to be present) and particularly requires the production code to contain (hidden) fields even if they would not be required just to provide according tests. This change replaces the reflective access with widget extraction functionality based on explicit IDs assigned to the UI elements of interest. Fixes eclipse-platform#2060
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this issue
Sep 30, 2024
The tests for the FindReplaceDialog and FindReplaceOverlay currently use reflection to access specific UI elements. This ties the test implementations to implementation details of the production classes (i.e., specific hidden field to be present) and particularly requires the production code to contain (hidden) fields even if they would not be required just to provide according tests. This change replaces the reflective access with widget extraction functionality based on explicit IDs assigned to the UI elements of interest. Fixes eclipse-platform#2060
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this issue
Oct 1, 2024
The tests for the FindReplaceDialog and FindReplaceOverlay currently use reflection to access specific UI elements. This ties the test implementations to implementation details of the production classes (i.e., specific hidden field to be present) and particularly requires the production code to contain (hidden) fields even if they would not be required just to provide according tests. This change replaces the reflective access with widget extraction functionality based on explicit IDs assigned to the UI elements of interest. Fixes eclipse-platform#2060
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In this PR (#1990), some of the setBackground operations are useless and only there so that I don't get a warning for unused fields. I need those fields to stay in the class so I can access them in a test.
What is the best solution here?
The text was updated successfully, but these errors were encountered: