Find/replace overlay: does not take focus after detach #2246
Labels
Comments
|
Thank you for reporting this. The NPE should be fixed via #2247. I can also reproduce some of the other exceptions. But to do so, I have to reattach an editor to another shell (so that the shell of the detached editor is disposed). I cannot reproduce the behavior of improper focus when the editor is detached. When following the described use case (detach editor, open overlay, enter something), the overlay is properly opened and focused and receives the input for me. |
|
i can reproduce detach focus every time. here is a video: |
|
and still get |
|
From my understanding, these exception occur when reattaching. I was not able to produce them by detaching so far. Maybe I am doing something differently. I was able to produce some detach focus issue, but in my case it is different from your behavior: when pressing CTRL+F in the detached window, the find/replace is opened for the active editor in the original shell rather than the in the detached shell, and also that one receives focus. But that is an existing problem of the I would like to push #2254 forward, as it is supposed to solve several issues (including this one) and make the UI integration way cleaner, as it gets rid of the additional shell instantiated for the overlay. In case that solution does not prove to work out, I will come back to addressing specifically this issue. |
61 tasks
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this issue
Oct 3, 2024
…-platform#2099 The FindReplaceOverlay is currently realized as a separate shell (more precisely, a JFace Dialog), which is placed at a proper position on top of the workbench shell. This has some drawback: - It has to manually adapt to movements of the parent shell or the target part/widget - It has to manually hide and show depending on visibility changes of the target part/widget - It does not follow events of the target immediately, i.e., movements are always some milliseconds behind, minimize/maximize operations/animations are not synchronous etc. - It does not locate properly when the platform uses Wayland, as manual shell positioning is not possible there This change replaces the dialog-based implementation of the FindReplaceOverlay with an in-place composite-based implementation. A composite is created in the target widget and placed relative to this composite. In consequence, the overlay automatically follows all move, resize, hide/show operations of the target widget. Fixes eclipse-platform/eclipse.platform.swt#1447 Fixes eclipse-platform#2099 Fixes eclipse-platform#2246
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this issue
Oct 3, 2024
…-platform#2099 The FindReplaceOverlay is currently realized as a separate shell (more precisely, a JFace Dialog), which is placed at a proper position on top of the workbench shell. This has some drawback: - It has to manually adapt to movements of the parent shell or the target part/widget - It has to manually hide and show depending on visibility changes of the target part/widget - It does not follow events of the target immediately, i.e., movements are always some milliseconds behind, minimize/maximize operations/animations are not synchronous etc. - It does not locate properly when the platform uses Wayland, as manual shell positioning is not possible there This change replaces the dialog-based implementation of the FindReplaceOverlay with an in-place composite-based implementation. A composite is created in the target widget and placed relative to this composite. In consequence, the overlay automatically follows all move, resize, hide/show operations of the target widget. Fixes eclipse-platform/eclipse.platform.swt#1447 Fixes eclipse-platform#2099 Fixes eclipse-platform#2246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
on Windows OS:
open an editor
detach it (drag to another screen or "detach" in the tabs context menu)
press strg+f -> opens search
enter "hallo"
-> "hallo" edits the document. it is supposed to be written in the search dialog
After detaaching mutliple times it is sometimes not possible to open Find/replace overlay at all.
Errors found in the error log:
The text was updated successfully, but these errors were encountered: