Reverting the bg color for StyledText, Button, Table controls

[mvm-sap]

Reverting the changes done to bg colors of controls like StyledText, Button, Table in views.
Selected tab in TabbedPropertyList had grey background in view, even that has been changed to white with this change.
Issue #2173 has been addressed with this change.
Please again test and provide feedback if there are still some issues.

Below are the screenshots

Before:

After:

[BeckerWdf]

@Phillipus: Can you pls. review and test?

[github-actions]

Test Results

 1 815 files  +  605   1 815 suites  +605   1h 33m 50s ⏱️ + 27m 52s
 7 688 tests ±    0   7 460 ✅ +    3  228 💤  -   3  0 ❌ ±0 
24 225 runs  +8 075  23 476 ✅ +7 839  749 💤 +236  0 ❌ ±0 

Results for commit 403317f. ± Comparison against base commit 26102ed.

[Phillipus]

Thanks for the PR. I tested this with our RCP app and can confirm that the StyledText, Button controls in views and the selected tab in TabbedPropertyList are white in the light theme and the Table control has alternate row colors on Mac.

One slight issue on Mac is the background in a Label in a Group control:

However, the same problem occurs in the current light theme on Mac.

[BeckerWdf]

However, the same problem occurs in the current light theme on Mac.

So this has to be handled separately..

[Phillipus]

So this has to be handled separately..

The following on Mac seems to fix it:

.View Group Label {
    background-color: unset;
}

[tomaswolf]

Just noticed: the gray unstaged/staged changes trees in that abapGit view (probably also in the eGit staging view?) also look like they were disabled. (Perhaps they are, since there are no changes...) Perhaps trees inside forms also should be styled with a white background. How does e.g. the PDE manifest editor look with that new styling?

[Phillipus]

How does e.g. the PDE manifest editor look with that new styling?

If it's an EditPart it's not affected. This change affects controls in ViewParts. But if those same form-based controls are in a ViewPart they're grey.

Trees in ViewParts are grey so if you depend on that to show disabled state of a Tree you're out of luck.

[mvm-sap]

So this has to be handled separately..

The following on Mac seems to fix it:

.View Group Label {
    background-color: unset;
}

If we unset, it will affect other views, find below the screenshot. This is in windows, might aswell affect Mac

I feel its better to set it this way:

.View Group Label{
background-color: inherit;
}

What do you think?

[BeckerWdf]

Just noticed: the gray unstaged/staged changes trees in that abapGit view (probably also in the eGit staging view?) also look like they were disabled. (Perhaps they are, since there are no changes...) Perhaps trees inside forms also should be styled with a white background. How does e.g. the PDE manifest editor look with that new styling?

With this change or before this change?

[mvm-sap]

Just noticed: the gray unstaged/staged changes trees in that abapGit view (probably also in the eGit staging view?) also look like they were disabled. (Perhaps they are, since there are no changes...) Perhaps trees inside forms also should be styled with a white background. How does e.g. the PDE manifest editor look with that new styling?

Yes, Staged and Unstaged will have grey backgrounds, as we have set the bg for a tree as grey in views.

[BeckerWdf]

Can we merge this change?

[BeckerWdf]

and the Table control has alternate row colors on Mac.

I don't see that on my Mac. Where do you see that? Can you show a screenshot?

[Phillipus]

I feel its better to set it this way:

background-color: inherit;
}

What do you think?

That doesn't work. As I said it's Mac only so only belongs in the Mac CSS file .

[Phillipus]

and the Table control has alternate row colors on Mac.

I don't see that on my Mac. Where do you see that? Can you show a screenshot?

This PR reverts the grey table so the alternate row colors is expected and desired (as it used to be).

[BeckerWdf]

If nobody objects I will merge this today.

[BeckerWdf]

Thanks for the PR. I tested this with our RCP app and can confirm that the StyledText, Button controls in views and the selected tab in TabbedPropertyList are white in the light theme and the Table control has alternate row colors on Mac.

One slight issue on Mac is the background in a Label in a Group control:

However, the same problem occurs in the current light theme on Mac.

So this existed already even before @mvm-sap's changes? If yes. Pls. open a separate issue. And if you already have a solution proposal pls. also send a PR for it.