Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StickyScrolling] Refactoring sticky lines provider and handler #2266

Conversation

Christopher-Hermann
Copy link
Contributor

Refactors the sticky lines provider and extract the method to an interface. This is a preparation step for providing a extension point for sticky lines provider.

Copy link
Contributor

github-actions bot commented Sep 13, 2024

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 33m 34s ⏱️ - 2m 3s
 7 699 tests ±0   7 471 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 258 runs  ±0  23 511 ✅ ±0  747 💤 ±0  0 ❌ ±0 

Results for commit 91997cd. ± Comparison against base commit c603575.

This pull request removes 10 and adds 10 tests. Note that renamed tests count towards both.
org.eclipse.ui.internal.texteditor.stickyscroll.StickyLinesProviderTest ‑ testEmptySourceCode
org.eclipse.ui.internal.texteditor.stickyscroll.StickyLinesProviderTest ‑ testIgnoreEmptyLines
org.eclipse.ui.internal.texteditor.stickyscroll.StickyLinesProviderTest ‑ testLineUnderStickyLine
org.eclipse.ui.internal.texteditor.stickyscroll.StickyLinesProviderTest ‑ testLinesWithTabs
org.eclipse.ui.internal.texteditor.stickyscroll.StickyLinesProviderTest ‑ testNewStickyRoot
org.eclipse.ui.internal.texteditor.stickyscroll.StickyLinesProviderTest ‑ testRemoveStickyLines
org.eclipse.ui.internal.texteditor.stickyscroll.StickyLinesProviderTest ‑ testSingleStickyLine
org.eclipse.ui.internal.texteditor.stickyscroll.StickyLinesProviderTest ‑ testSourceViewerWithDifferentModelAndWindgetLines
org.eclipse.ui.internal.texteditor.stickyscroll.StickyLinesProviderTest ‑ testStartAtEmptyLineWithNext
org.eclipse.ui.internal.texteditor.stickyscroll.StickyLinesProviderTest ‑ testStartAtEmptyLineWithPrevious
org.eclipse.ui.internal.texteditor.stickyscroll.DefaultStickyLinesProviderTest ‑ testEmptySourceCode
org.eclipse.ui.internal.texteditor.stickyscroll.DefaultStickyLinesProviderTest ‑ testIgnoreEmptyLines
org.eclipse.ui.internal.texteditor.stickyscroll.DefaultStickyLinesProviderTest ‑ testLineUnderStickyLine
org.eclipse.ui.internal.texteditor.stickyscroll.DefaultStickyLinesProviderTest ‑ testLinesWithTabs
org.eclipse.ui.internal.texteditor.stickyscroll.DefaultStickyLinesProviderTest ‑ testNewStickyRoot
org.eclipse.ui.internal.texteditor.stickyscroll.DefaultStickyLinesProviderTest ‑ testRemoveStickyLines
org.eclipse.ui.internal.texteditor.stickyscroll.DefaultStickyLinesProviderTest ‑ testSingleStickyLine
org.eclipse.ui.internal.texteditor.stickyscroll.DefaultStickyLinesProviderTest ‑ testSourceViewerWithDifferentModelAndWindgetLines
org.eclipse.ui.internal.texteditor.stickyscroll.DefaultStickyLinesProviderTest ‑ testStartAtEmptyLineWithNext
org.eclipse.ui.internal.texteditor.stickyscroll.DefaultStickyLinesProviderTest ‑ testStartAtEmptyLineWithPrevious

♻️ This comment has been updated with latest results.

@Christopher-Hermann
Copy link
Contributor Author

Failing test is unrelated.

@BeckerWdf
Copy link
Contributor

I just read through very briefly..

Refactors the sticky lines provider and extract the method to an interface. This is a preparation step for providing a extension point for sticky lines provider.
@Christopher-Hermann Christopher-Hermann merged commit 0fa0c4b into eclipse-platform:master Sep 26, 2024
16 checks passed
@Christopher-Hermann Christopher-Hermann deleted the stickyScrollingRefactoring branch September 26, 2024 13:30
@BeckerWdf BeckerWdf added this to the 4.34 M1 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants