-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "Close mode" frame in editor preference #2298
base: master
Are you sure you want to change the base?
Added "Close mode" frame in editor preference #2298
Conversation
My suggestion would be to merge both settings into one line instead of grouping them e.g.
|
What about "Closing behaviour"? |
This is also a good idea. |
Change-Id: I6a08929ccbfea821f5b9a30097503c10d3bcf916
Can the input field made shorter so that the line doesn't get too long. I think place for around 4 chars would be sufficient. What about changing the text to: "Close oldest editor if there more then ... editor open" What does "oldest" mean? |
I checked the current behaviour and noticed that it's not always the oldest editors that are being closed. Use case 1:If I have the following editors opened in order:
It deletes the latest 3 editors (6, 5, 4) and replaces the oldest editor. Use case 2:If I have the following editors opened in order:
It deletes the latest 3 editors (5, 6, 4) and replaces the oldest editor (1). Use case 3:If I have the following editors opened in order:
It deletes the latest 3 editors (2, 6, 5) and replaces the oldest editor (1). Use case 4:If I have the following editors opened in order:
It replaces the oldest editor (1). Use case 5:If I have the following editors opened in order:
It replaces the oldest editor (2). |
It looks like its not always the oldest editors that are being closed. |
yes. |
|
Issue: #2297
This pull request adds a "Close mode" frame in the editor preference to make the "Close editors automatically" and "Number of opened editors before closing" grouping clear.