Find/replace dialog: properly update search string #2322 #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The find/replace dialog does currently not properly update its search string. When changing the search string and pressing return to execute a search, the previous search string is taken. The reason is an existing workaround for event handling of Combos in GTK. This change ensures that the search and replace input strings are properly updated upon every text modification in the according widgets. Fixes eclipse-platform#2322
|
Looks sound, however I wonder if it wouldn't be better to completely get rid of the combo boxes and use the input-element that the overlay uses.
|
|
That might be a follow-up change. Still it has the risk of introducing regressions in the dialog, so we need to weigh that against the benefits of making that change. Aliging the two UIs makes sense, but we should ensure that the existing dialog remains usable in the same way as now for everyone sticking to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The find/replace dialog does currently not properly update its search string. When changing the search string and pressing return to execute a search, the previous search string is taken. The reason is an existing workaround for event handling of Combos in GTK.
This change ensures that the search and replace input strings are properly updated upon every text modification in the according widgets.
Fixes #2322