Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression on marker updates from #984 #994

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

iloveeclipse
Copy link
Member

See 7da51e7 and comment from Denis Ungemach on #984

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Test Results

     852 files  ±0       852 suites  ±0   1h 11m 45s ⏱️ - 2m 33s
  7 207 tests ±0    7 056 ✔️  - 2  149 💤 ±0  2 +2 
22 767 runs  ±0  22 278 ✔️  - 2  487 💤 ±0  2 +2 

For more details on these failures, see this check.

Results for commit e79205f. ± Comparison against base commit 3071205.

@iloveeclipse
Copy link
Member Author

@DenisUngemach : could you please review?

@iloveeclipse iloveeclipse merged commit b5dac3e into eclipse-platform:master Aug 4, 2023
12 of 14 checks passed
@iloveeclipse iloveeclipse deleted the pr_984_fix branch August 4, 2023 05:38
Copy link
Contributor

@DenisUngemach DenisUngemach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is exactly what i meant. I think the method changeAttributes should be fine as public API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants