fix Console Scroll Lock is disabled with key "End" without CTRL #648

[jukzi]

only ctrl+end should disable Scroll Lock

#648

[github-actions]

Test Results

       42 files  ±0         42 suites  ±0   1h 2m 25s ⏱️ + 10m 52s
  3 770 tests ±0    3 766 ✔️ ±0    3 💤 ±0  1 ❌ ±0 
11 313 runs  ±0  11 283 ✔️ ±0  27 💤 ±0  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit 5b84d71. ± Comparison against base commit 3baaffe.

♻️ This comment has been updated with latest results.

[HeikoKlare]

I agree that only CTRL+END should disable scroll lock (and not just pressing END).
The change works as expected.

One observation: Pressing DOWN still disables scroll lock. Personally, I find this quite unintuitive (just like pressing END disabling scroll lock). So I would prefer to apply the CTRL mask check to both END and DOWN/BOTTOM here.

[jukzi]

So I would prefer to apply the CTRL mask check to both END and DOWN/BOTTOM here.

If you reach the bottom of the log with the down key it was intentional to end scroll lock again. Therefore for "down" there is the additional condition checkEndOfDocument(). - However to my experience that condition sometimes yield true to early - when coming near to the end. Would be another topic to fix that.

[HeikoKlare]

I see. I mistook the check for SWT.BOTTOM to be related to pressing the arrow down button, but it's actually another condition that also checks for end of document, as you point to. So nothing to address in this PR.