TextConsoleViewer Scrolling #719
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 558 files - 78 558 suites - 78 24m 29s ⏱️ - 15m 31s Results for commit 7782daa. ± Comparison against base commit 31e1ef4. This pull request removes 593 tests.♻️ This comment has been updated with latest results. |
fedejeanne
reviewed
Sep 29, 2023
| @@ -306,11 +293,13 @@ public void keyPressed(KeyEvent e) { | |||
| if (isAutoScrollLockNotApplicable()) { | |||
There was a problem hiding this comment.
You could rewrite this whole lambda like this:
if (isAuto... || e.count == 0) {
return;
}
setScrollLock(e.count > 0 || !isAtEndOfDocument());
fedejeanne
reviewed
Sep 29, 2023
Comment on lines
+167
to
+168
| * Checks if user preference is enabled for auto scroll lock. and if the view is | ||
| * empty or the content is minimal, implying no need for scrolling. |
There was a problem hiding this comment.
Suggested change
| * Checks if user preference is enabled for auto scroll lock. and if the view is | |
| * empty or the content is minimal, implying no need for scrolling. | |
| * Checks if the auto scrolling is not applicable based on: | |
| <ul> | |
| <li>Whether or not the appropriate user preference is enabled</li> | |
| <li>Whether or not there is enough content to even require scrolling</li> | |
| </ul> |
jukzi
force-pushed
the
TextConsoleViewer_Scrolling
branch
from
0ed9a2f
to
7782daa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve logic for auto-enable/-disable of scroll lock in TextConsoleViewer #669