Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Make sure extension developers compile against ES5 #6761

Open
kittaakos opened this issue Dec 17, 2019 · 4 comments
Open

[doc] Make sure extension developers compile against ES5 #6761

kittaakos opened this issue Dec 17, 2019 · 4 comments
Labels
documentation issues related to documentation quality issues related to code and application quality

Comments

@kittaakos
Copy link
Contributor

Description

Compiling against es6 can cause strange behavior at runtime. See #6740 (comment). If it is a known limitation, we need to "advertise" it better among the extension developers. It took me some time to figure out what was the problem.

If it is a known limitation

Is it?
CC: @akosyakov

Reproduction Steps

OS and Theia version:

Diagnostics:

@kittaakos kittaakos added quality issues related to code and application quality documentation issues related to documentation labels Dec 17, 2019
@akosyakov
Copy link
Member

Yes, for now, it would be safer to use es5.

@vince-fugnitto
Copy link
Member

Where would be the best place(s) to advertise which target to compile to for extension developers?

@akosyakov
Copy link
Member

Honestly, i thought that everyone is using theia extension generator to get started or copy configs from existing extensions. In both cases it should be es5. Such thing can happen only if someone intentionally switched to es6 without giving a thought to it.

@mikael-desharnais
Copy link
Contributor

You have to add "skipLibCheck": true to your tsconfig.json. I had the exact same problem an hour ago, so I am going to close it. Also, make sure you compile against ES5: "target": "es5",.

Sorry but isn't it a bit ugly to skipLibCheck ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation quality issues related to code and application quality
Projects
None yet
Development

No branches or pull requests

4 participants