GH-8361: Fixed editor resizing issue in Output. #8362
Conversation
Closes #8361. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
| @@ -147,6 +147,11 @@ export class OutputWidget extends BaseWidget implements StatefulWidget { | |||
| } | |||
| } | |||
|
|
|||
| protected onAfterShow(msg: Message): void { | |||
| super.onAfterShow(msg); | |||
| this.onResize(Widget.ResizeMessage.UnknownSize); // Triggers an editor widget resize. (#8361) | |||
There was a problem hiding this comment.
I wonder what is the difference to explicit this.editor.refresh();.
In EditorWidget we do it, we do it as well for onAfterAttach to resize it if a widget gets moved between areas.
There was a problem hiding this comment.
Yes, I started by calling editor.refresh() but it did not fix the problem.
There was a problem hiding this comment.
this.autoSizing is false in the monaco editor, so calling refresh is a NOOP.
There was a problem hiding this comment.
It turned out, calling editor.refresh() does nothing at all when invoked from EditorWidget#onAfterShow. autoSizing is always false.
There was a problem hiding this comment.
In
EditorWidgetwe do it, we do it as well foronAfterAttachto resize it if a widget gets moved between areas.
I have tried opening, maximizing, and DNDing editors while having breakpoints on both onAfterAttach and onAfterShow in the editor widget:
Neither of them has any effect as the underlying monaco editor's autoresize is a noop.
There was a problem hiding this comment.
Maybe, somehow related to the old issue? microsoft/monaco-editor#794
Closes #8361.
Signed-off-by: Akos Kitta kittaakos@typefox.io
What it does
Fixes the editor resizing issue in the Output view.
How to test
API sampleOutput channel is visible.Before:
After:
Review checklist
Reminder for reviewers