Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ 17° ] - Release/v2.1.0/trg 4 02 & trg 4.03: updated container base images and adjusted user ids #202

Merged

Conversation

saudkhan116
Copy link
Contributor

Why we create this PR?

This PR contains the following changes:

  • Updated versions from container base images to the ones described here aligned-base-images
  • Adjusted the non root user ids in Dockerfiles and dpp helm chart configurations

What we want to achieve with this PR?

To be compliant with the following release guidelines from quality gates:

What is new?

Updated

  • Updated versions from container base images
  • Adjusted the non root user ids in Dockerfiles and dpp helm chart configurations

@saudkhan116 saudkhan116 added helm-charts Issue or PR connected to the helm charts configuration docker Issue or PR connected to the docker configuration labels Feb 2, 2024
@saudkhan116 saudkhan116 added this to the v2.1.0 milestone Feb 2, 2024
@saudkhan116 saudkhan116 changed the title Release/v2.1.0/trg 4 02 & trg 4.03: updated container base images and adjusted user ids [ 17° ] - Release/v2.1.0/trg 4 02 & trg 4.03: updated container base images and adjusted user ids Feb 2, 2024
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KICS found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@@ -62,15 +63,15 @@
HEALTHCHECK NONE

# add permissions for a user
RUN chown -R 10000:3000 /app && chmod -R 775 /app/
RUN chown 10000:3000 /entrypoint.sh && chmod -R 775 /entrypoint.sh
RUN chown -R 1000:3000 /app && chmod -R 775 /app/

Check notice

Code scanning / KICS

Multiple RUN, ADD, COPY, Instructions Listed Note

There are RUN instructions that could be grouped
@saudkhan116 saudkhan116 merged commit a60981c into eclipse-tractusx:main Feb 2, 2024
7 of 8 checks passed
@saudkhan116 saudkhan116 deleted the release/v2.1.0/trg-4-02 branch February 2, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Issue or PR connected to the docker configuration helm-charts Issue or PR connected to the helm charts configuration
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants