Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new release 23.12 #540

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Conversation

manojava-gk
Copy link
Contributor

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@Siegfriedk Siegfriedk merged commit 3606ed7 into eclipse-tractusx:main Dec 8, 2023
4 checks passed
@carslen
Copy link
Contributor

carslen commented Dec 8, 2023

Eclipse-Tractus-X should not:

  • reference potentially short lived forks in its KITS documentation:
    grafik

  • reference volatile branches in versioned documentation, as content may change (in main branch):
    grafik

  • reference to previously used repositories in catenax-ng repository:
    grafik

  • link to outdated repositories/dependencies (MIW repo in plural (wallets) is outdated,the singular (wallet) repo should be linked instead) and of course not linking to a fork:
    grafik

  • accept and merge huge PRs like this one under time pressure because of release date.

These are only quick findings. There may be many more problems, but they could remain undiscovered due to the size of the PR and quality of the review and the time pressure (release date!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants