chore(products/repositories): adapt/update whole list of products/repositories #968

stephanbcbauer · 2024-07-07T19:08:22Z

Description

The main purpose for this PR is to update our product list. It's old and not up to date. The initial idea was to publish all our active products in this list. Since we are always asking about the responsible committer for each repository, I tried to update the list for each repository depending on the committers' contribution to the repository.

What is needed in this PR @eclipse-tractusx/automotive-tractusx-committers, please have a look at your product, repositories or where you are listed as committer. Is this correct? Is there a description or something missing within your product? Should we describe something more in detail? Would be happy about your sugestions.

Goal

If this PR is merged (hopefully we can do this) we would have a list of all products/repositories and the related committer which is responsible for this product/repository.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
Copyright and license header are present on all affected files

tom-rm-meyer-ISST

reviewed for puris / myself

utils/products.js

…ss-kit repo

matbmoser · 2024-07-08T09:19:25Z

Ok, I have updated our Digital Product Pass product description and configurations. I also removed the eco pass kit repo, since it is not really a product and it is archived.

matbmoser

At least from my side I can approve the merge.

SebastianBezold

If this list was generated by a script or similar, it should maybe be re-run without taking archived repos into account.
I already suggested in the past, that if this list is maintained here, we should maybe automate it with the same logic as the TRG dashboard is generated: https://eclipse-tractusx.github.io/sig-release/
This dashboard already groups repos to products and also ignores archived repos. SIGs and supporting repos are also already separated.
Maybe both approaches (website + dashboard) can be combined, so that there is no duplication and manual effort.

@almadigabor and @tomaszbarwicki: Could you two please double check this PR explicitly? You are referenced in a lot of product, where I guess you did TRG checks or merged contributions. I guess you are not actually involved in all of the products

utils/products.js

almadigabor · 2024-07-11T06:53:53Z

If this list was generated by a script or similar, it should maybe be re-run without taking archived repos into account. I already suggested in the past, that if this list is maintained here, we should maybe automate it with the same logic as the TRG dashboard is generated: https://eclipse-tractusx.github.io/sig-release/ This dashboard already groups repos to products and also ignores archived repos. SIGs and supporting repos are also already separated. Maybe both approaches (website + dashboard) can be combined, so that there is no duplication and manual effort.

@almadigabor and @tomaszbarwicki: Could you two please double check this PR explicitly? You are referenced in a lot of product, where I guess you did TRG checks or merged contributions. I guess you are not actually involved in all of the products

Hey @SebastianBezold, I had a look at the products where I'm listed as committer and added comments where I see fit.

stephanbcbauer · 2024-09-25T16:40:01Z

Thank you, @eclipse-tractusx/automotive-tractusx-committers for your review and feedback.

Hopefully, I changed everything like expected. @almadigabor @tomaszbarwicki on your side, I am still not sure, please have a look again. Thank you very much.

tom-rm-meyer-ISST

Walked through in more detail. I proposed productDescription for central or non-committer repos.

Also there are non-existing repos listed, I would remove or split.

tom-rm-meyer-ISST · 2024-09-26T05:21:58Z

utils/products.js

  {
    productName: "IDS Essential Services",
-    productDescription: "The project provides additional services to enable an IDSA-infrastructure within the Catena-X dataspace.",
+    productDescription:
+      "The project provides additional services to enable an IDSA-infrastructure within the Catena-X dataspace.",
    githubRepo: [
      "https://github.com/eclipse-tractusx/daps-registration-service",


Aren't the daps and its registration service ready for deprecation?

tom-rm-meyer-ISST · 2024-09-26T05:23:54Z

utils/products.js

+  },
+  {
+    productName: "managed-identity-wallet",
+    productDescription: "TBD",


committers available, thus product description MUST be set

tom-rm-meyer-ISST · 2024-09-26T05:24:02Z

utils/products.js

-    productName: "Generic Data Services",
-    productDescription: "The project provides an easy-to-use service which enables small and medium sized companies to provide their data in the Catena-X dataspace via an EDC (e.g., CSV-Upload).",
+    productName: "managed-service-orchestrator",
+    productDescription: "TBD",


committers available, thus product description MUST be set

tom-rm-meyer-ISST · 2024-09-26T05:24:13Z

utils/products.js

-    productName: "Item Relationship Service",
-    productDescription: "The project provides a service for ad-hoc data chains across n-tier values chains for different use cases based on the EDC.",
+    productName: "managed-simple-data-exchanger",
+    productDescription: "TBD",


committers available, thus product description MUST be set

tom-rm-meyer-ISST · 2024-09-26T05:29:55Z

utils/products.js

  },
-
  {
    productName: "Semantic Layer & Digital Twin",


Where does this project come from? It has been a team and this is a summary of all products belonging to the team.

What's this list's target? If it's about listing products and repositories I would expect them to be separated because e.g. an adopter does not need to use all of these services to have one application runnint (e.g. frontend, backend, documentation, etc. for portal). Then only the leading repository of the .tractusx needs to be listed.

tom-rm-meyer-ISST · 2024-09-26T05:32:20Z

utils/products.js

+  },
+  {
+    productName: "vas-country-risk",
+    productDescription: "TBD",


Suggested change

productDescription: "TBD",

productDescription: "The Catena-X Country Risk project is a web application that calculates a risk score per country based on information regarding corruption, political stability, economic risk, and social and structural figures.",

tom-rm-meyer-ISST · 2024-09-26T05:32:54Z

utils/products.js

@@ -1,152 +1,372 @@
 export const products = [
+  {
+    productName: "api-hub",
+    productDescription: "TBD",


Suggested change

productDescription: "TBD",

productDescription: "Welcome to the API Hub repository, a centralized location for hosting and viewing API documentation for the Tractus-X organization. This repository automates the collection of OpenAPI specifications from GitHub releases, generates Swagger UI documentation, and publishes it on GitHub Pages.",

tom-rm-meyer-ISST · 2024-09-26T05:37:36Z

utils/products.js

+    hasBoard: true,
+    showVersion: true,
+  },
+  {


This product forwards to another github project & repo, likely as this has been moved to be handled by the EF working groups more independent of Eclipse Tractus-X.

Recommend removing

Yes, should be removed, https://github.com/eclipse-tractusx/identity-trust moved to https://github.com/eclipse-dataspace-dcp/decentralized-claims-protocol

tom-rm-meyer-ISST · 2024-09-26T05:38:27Z

utils/products.js

-      "https://github.com/eclipse-tractusx/policy-hub"
-    ],
+    productName: "tractusx-profiles",
+    productDescription: "TBD",


Suggested change

productDescription: "TBD",

productDescription: "Defines Credential and Policy Profiles for Tractus-X.",

tom-rm-meyer-ISST · 2024-09-26T05:39:23Z

utils/products.js

+    showVersion: true,
+  },
+  {
+    productName: "quality-dashboard",


product not available

I assume the app-dashboard but that's not a product

stephanbcbauer · 2024-09-26T05:56:19Z

Walked through in more detail. I proposed productDescription for central or non-committer repos.

Also there are non-existing repos listed, I would remove or split.

Will have a look. Thx @tom-rm-meyer-ISST

evegufy

could you please also update the PR description, for instance the following statement is obsolete:

If there wasn't an active committer, I put @evegufy and myself as responsible committer. Of course, we can adapt this. I also deleted the committer, where we already know they are not present after the end of consortium.

evegufy · 2024-09-26T05:46:37Z

utils/products.js

+    hasBoard: true,
+    showVersion: true,
+  },
+  {


Yes, should be removed, https://github.com/eclipse-tractusx/identity-trust moved to https://github.com/eclipse-dataspace-dcp/decentralized-claims-protocol

evegufy · 2024-09-26T05:49:53Z

utils/products.js

      "https://github.com/eclipse-tractusx/daps-registration-service",
      "https://github.com/eclipse-tractusx/daps-helm-chart",


the two repos should be removed and the product be changed to Self-Description Factory.

evegufy · 2024-09-26T05:52:15Z

utils/products.js

+    showVersion: true,
+  },
+  {
+    productName: "quality-dashboard",


I assume the app-dashboard but that's not a product

matbmoser · 2024-10-05T12:20:10Z

LGTM we should merge this ASAP, in worst case another PR should be created

stephanbcbauer added 2 commits July 7, 2024 20:48

adapt/update whole list of products/repositories

fbbd800

re-add changelog and discovery-finder-openapi files

af81afc

stephanbcbauer added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 7, 2024

stephanbcbauer requested a review from a team July 7, 2024 19:08

stephanbcbauer self-assigned this Jul 7, 2024

tom-rm-meyer-ISST requested changes Jul 8, 2024

View reviewed changes

utils/products.js Outdated Show resolved Hide resolved

utils/products.js Outdated Show resolved Hide resolved

evegufy requested changes Jul 8, 2024

View reviewed changes

matbmoser reviewed Jul 8, 2024

View reviewed changes

utils/products.js Outdated Show resolved Hide resolved

matbmoser added 2 commits July 8, 2024 11:15

chore(dpp): added details for digital product pass and removed eco-pa…

6083994

…ss-kit repo

chore(dpp): fixed typos in dpp description

154ca76

matbmoser previously approved these changes Jul 8, 2024

View reviewed changes

SebastianBezold suggested changes Jul 8, 2024

View reviewed changes

utils/products.js Outdated Show resolved Hide resolved

utils/products.js Outdated Show resolved Hide resolved

utils/products.js Outdated Show resolved Hide resolved

mhellmeier reviewed Jul 8, 2024

View reviewed changes

utils/products.js Outdated Show resolved Hide resolved

mhellmeier requested changes Jul 8, 2024

View reviewed changes

utils/products.js Outdated Show resolved Hide resolved

utils/products.js Outdated Show resolved Hide resolved

utils/products.js Outdated Show resolved Hide resolved

SujitMBRDI reviewed Jul 8, 2024

View reviewed changes

utils/products.js Outdated Show resolved Hide resolved

SujitMBRDI reviewed Jul 8, 2024

View reviewed changes

utils/products.js Outdated Show resolved Hide resolved

SujitMBRDI reviewed Jul 8, 2024

View reviewed changes

utils/products.js Outdated Show resolved Hide resolved

almadigabor reviewed Jul 11, 2024

View reviewed changes

utils/products.js Show resolved Hide resolved

almadigabor reviewed Jul 11, 2024

View reviewed changes

utils/products.js Outdated Show resolved Hide resolved

revert changes in file

540d694

stephanbcbauer dismissed matbmoser’s stale review via 540d694 September 25, 2024 16:10

adapt product list after review

6742650

stephanbcbauer requested review from almadigabor, SujitMBRDI, tom-rm-meyer-ISST, mhellmeier and SebastianBezold September 25, 2024 16:38

stephanbcbauer requested review from evegufy and matbmoser September 25, 2024 16:38

tom-rm-meyer-ISST requested changes Sep 26, 2024

View reviewed changes

evegufy reviewed Sep 26, 2024

View reviewed changes

matbmoser approved these changes Oct 5, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(products/repositories): adapt/update whole list of products/repositories #968

chore(products/repositories): adapt/update whole list of products/repositories #968

stephanbcbauer commented Jul 7, 2024 •

edited

Loading

tom-rm-meyer-ISST left a comment

matbmoser commented Jul 8, 2024

matbmoser left a comment

SebastianBezold left a comment

almadigabor commented Jul 11, 2024

stephanbcbauer commented Sep 25, 2024 •

edited

Loading

tom-rm-meyer-ISST left a comment

tom-rm-meyer-ISST Sep 26, 2024

tom-rm-meyer-ISST Sep 26, 2024

tom-rm-meyer-ISST Sep 26, 2024

tom-rm-meyer-ISST Sep 26, 2024

tom-rm-meyer-ISST Sep 26, 2024

tom-rm-meyer-ISST Sep 26, 2024

tom-rm-meyer-ISST Sep 26, 2024

tom-rm-meyer-ISST Sep 26, 2024

evegufy Sep 26, 2024

tom-rm-meyer-ISST Sep 26, 2024

tom-rm-meyer-ISST Sep 26, 2024

evegufy Sep 26, 2024

stephanbcbauer commented Sep 26, 2024

evegufy left a comment

evegufy Sep 26, 2024

evegufy Sep 26, 2024

evegufy Sep 26, 2024

matbmoser commented Oct 5, 2024

	productDescription: "TBD",
	productDescription: "The Catena-X Country Risk project is a web application that calculates a risk score per country based on information regarding corruption, political stability, economic risk, and social and structural figures.",

	productDescription: "TBD",
	productDescription: "Welcome to the API Hub repository, a centralized location for hosting and viewing API documentation for the Tractus-X organization. This repository automates the collection of OpenAPI specifications from GitHub releases, generates Swagger UI documentation, and publishes it on GitHub Pages.",

	productDescription: "TBD",
	productDescription: "Defines Credential and Policy Profiles for Tractus-X.",

		"https://github.com/eclipse-tractusx/daps-registration-service",
		"https://github.com/eclipse-tractusx/daps-helm-chart",

chore(products/repositories): adapt/update whole list of products/repositories #968

Are you sure you want to change the base?

chore(products/repositories): adapt/update whole list of products/repositories #968

Conversation

stephanbcbauer commented Jul 7, 2024 • edited Loading

Description

Goal

Pre-review checks

tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

matbmoser commented Jul 8, 2024

matbmoser left a comment

Choose a reason for hiding this comment

SebastianBezold left a comment

Choose a reason for hiding this comment

almadigabor commented Jul 11, 2024

stephanbcbauer commented Sep 25, 2024 • edited Loading

tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stephanbcbauer commented Sep 26, 2024

evegufy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matbmoser commented Oct 5, 2024

stephanbcbauer commented Jul 7, 2024 •

edited

Loading

stephanbcbauer commented Sep 25, 2024 •

edited

Loading