feature: 420 fix filterExpression; refactor

eclipse-tractusx · Mar 6, 2024 · ab66790 · ab66790
1 parent 11e81dd
commit ab66790
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/...ava/org/eclipse/tractusx/irs/edc/client/contract/service/EdcContractAgreementService.java b/...ava/org/eclipse/tractusx/irs/edc/client/contract/service/EdcContractAgreementService.java
@@ -19,7 +19,6 @@
  ********************************************************************************/
 package org.eclipse.tractusx.irs.edc.client.contract.service;
 
-import java.util.Arrays;
 import java.util.List;
 
 import lombok.extern.slf4j.Slf4j;
@@ -48,7 +47,7 @@
 public class EdcContractAgreementService {
 
     public static final String EDC_REQUEST_SUFFIX = "/request";
-    public static final String EDC_CONTRACT_AGREEMENT_ID = "https://w3id.org/edc/v0.0.1/ns/id";
+    public static final String EDC_CONTRACT_AGREEMENT_ID = "id";
     private final EdcConfiguration config;
     private final RestTemplate edcRestTemplate;
 
@@ -58,7 +57,7 @@ public EdcContractAgreementService(final EdcConfiguration config,
         this.edcRestTemplate = edcRestTemplate;
     }
 
-    public List<EdcContractAgreementsResponse> getContractAgreements(final String... contractAgreementIds)
+    public List<EdcContractAgreementsResponse> getContractAgreements(final List<String> contractAgreementIds)
             throws ContractAgreementException {
 
         final EdcContractAgreementRequest edcContractAgreementRequest = buildContractAgreementRequest(
@@ -89,9 +88,9 @@ public EdcContractAgreementNegotiationResponse getContractAgreementNegotiation(f
         return contractNegotiationResponseEntity.getBody();
     }
 
-    private EdcContractAgreementRequest buildContractAgreementRequest(final String... contractAgreementIds) {
+    private EdcContractAgreementRequest buildContractAgreementRequest(final List<String> contractAgreementIds) {
 
-        final List<EdcContractAgreementFilterExpression> list = Arrays.stream(contractAgreementIds)
+        final List<EdcContractAgreementFilterExpression> list = contractAgreementIds.stream()
                                                                       .map(s -> new EdcContractAgreementFilterExpression(
                                                                               EDC_CONTRACT_AGREEMENT_ID, "=", s))
                                                                       .toList();

diff --git a/...org/eclipse/tractusx/irs/edc/client/contract/service/EdcContractAgreementServiceTest.java b/...org/eclipse/tractusx/irs/edc/client/contract/service/EdcContractAgreementServiceTest.java
@@ -66,7 +66,7 @@ void setUp() {
     @Test
     void shouldReturnContractAgreements() throws ContractAgreementException {
         //GIVEN
-        String[] contractAgreementIds = { "contractAgreementId" };
+        List<String> contractAgreementIds = List.of("contractAgreementId");
 
         final EdcContractAgreementsResponse[] edcContractAgreementsResponse = new EdcContractAgreementsResponse[1];
         edcContractAgreementsResponse[0] = EdcContractAgreementsResponse.builder().contractAgreementId("id")
@@ -93,7 +93,7 @@ void shouldReturnContractAgreements() throws ContractAgreementException {
     @Test
     void shouldThrowContractAgreementExceptionWhenResponseBodyIsEmtpy() {
         //GIVEN
-        String[] contractAgreementIds = { "contractAgreementId" };
+        List<String> contractAgreementIds = List.of("contractAgreementId");
 
         when(restTemplate.exchange(anyString(), any(), any(), eq(EdcContractAgreementsResponse[].class))).thenReturn(
                 ResponseEntity.ok(new EdcContractAgreementsResponse[0]));