Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of aspect model SingleLevelBomAsBuilt 2.0.0 #296

Closed
3 of 10 tasks
Tracked by #212
mkanal opened this issue Nov 17, 2023 · 6 comments
Closed
3 of 10 tasks
Tracked by #212

Implementation of aspect model SingleLevelBomAsBuilt 2.0.0 #296

mkanal opened this issue Nov 17, 2023 · 6 comments
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request linked_to_feature Issue is linked to a feature

Comments

@mkanal
Copy link
Contributor

mkanal commented Nov 17, 2023

As business app
I want to receive SLBAB 2.0.0 aspects over the data chain
so that get results over the specific relationships defined by SLBAB 2.0.0

Hints / Details

Outcome / Acceptance Criteria

Outcome

  • ...

Acceptance Criteria

Implementation

  • relationships objects in JobResponse is extended with property "hasAlternatives"

Testdata

Testing

  • Testing: Multiple INT Test cases covering
    • SLBAB2.0.0 contains multiple asBuilt twins with hasAlternatives=false (Invalid collection)
    • SLBAB2.0.0 contains multiple asBuilt twins with hasAlternatives=true >> Semantic Models Batches
    • SLBAB2.0.0 contains multiple AsPlanned twins with hasAlternatives=true >> Semantic Models PartAsPlanned
    • SLBAB2.0.0 contains single AsPlanned twins with hasAlternatives=true >> Semantic Models PartAsPlanned
  • Testcases for multiple cases covering happy and incorrect suitution

Documentation

  • Update documentation for the multi lifecycle case: In case of receiving multi bomLifecycle the aspect array MUST contain semantic models of different bomLifecycles e.g. PartAsPlanned and SerialPart. !! IRS has the capability to switch bomLifeCyle (only for asBuilt) to provide asPlanned parts in a mixed stucture.

Out of Scope

  • ...
@mkanal mkanal assigned jzbmw and ds-jhartmann and unassigned jzbmw Nov 20, 2023
@jzbmw jzbmw added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 24, 2023
ds-jhartmann added a commit that referenced this issue Nov 28, 2023
chore(concept): rename propery from alternative to hasAlternatives
@ds-ext-kmassalski ds-ext-kmassalski self-assigned this Nov 30, 2023
@mkanal
Copy link
Contributor Author

mkanal commented Dec 5, 2023

@ds-ext-kmassalski and @ds-alexander-bulgakov
Will have a alignment on this issue and calrify what is necessary to resolve this ticekt including testing. The necessary experts Jon and Tomasz will be contacted to clarify the cases for testdata https://jira.catena-x.net/browse/TDG-34.
@ds-alexander-bulgakov will add the information to the ticekt:
There will be an update according to new insights in daily on 6.12.2023-

@ds-alexander-bulgakov
Copy link
Contributor

After a call with Tomasz Jacewski following informations are important:

  • The described four cases can not be reproduced in the testdata because
    • hasAlternatives=false is just theoretical and does not change anything
    • hasAlternatives=true is not possible to track since we can not assume a correlation between the marked parts and the lifecycle context of child parts

Therefore theoretically it is possible to have random "hasAlternatives=true" in the dataset and there is no chance to prove whether this is correct or not. There is no must to have several bomlifecycles in the aspects. This means the whole "Testing"-description is not possible to realize, we can only check if the response contains "hasAlternatives=true/(false)".
One more function would be to set parameter in the IRS to filter "hasAlternatives" in the response, but this seems not to be a requirement of this ticket.
For more information please see Tomaszs comment in TDG-34.

@jzbmw
Copy link
Contributor

jzbmw commented Dec 6, 2023

@ds-alexander-bulgakov is it possible to built all variants of that value "hasAlternative=true" in combination with the types of the child items into the testdataset.

hasAlternative = true
asBuilt --> batch
asBuilt --> asPlanned
asBuilt --> JIS

Then we would have a specific Testdataset with these setups, to which we can test.

@mkanal
Copy link
Contributor Author

mkanal commented Dec 6, 2023

One more function would be to set a parameter in the IRS to filter "hasAlternatives" in the response, but this seems not to be a requirement of this ticket. >> This is not a requirement we have.

ds-jhartmann pushed a commit that referenced this issue Dec 8, 2023
ds-jhartmann pushed a commit that referenced this issue Dec 8, 2023
ds-jhartmann pushed a commit that referenced this issue Dec 8, 2023
ds-jhartmann pushed a commit that referenced this issue Dec 8, 2023
ds-jhartmann added a commit that referenced this issue Dec 8, 2023
ds-jhartmann pushed a commit that referenced this issue Dec 8, 2023
…rnatives

feat(impl):[#296] has alternatives support
@jzbmw
Copy link
Contributor

jzbmw commented Dec 11, 2023

reviewed and accepted

@jzbmw jzbmw closed this as completed Dec 11, 2023
@mkanal mkanal added the linked_to_feature Issue is linked to a feature label Jan 15, 2024
@ds-alexander-bulgakov
Copy link
Contributor

Requested testdata has been created, see TDG-34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request linked_to_feature Issue is linked to a feature
Projects
Status: done
Development

No branches or pull requests

5 participants