Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to CodeQL & Dependabot #421

Merged
merged 5 commits into from
Apr 5, 2024
Merged

Switching to CodeQL & Dependabot #421

merged 5 commits into from
Apr 5, 2024

Conversation

scherersebastian
Copy link
Member

We're moving from Veracode to CodeQL and Dependabot. This switch brings better GitHub integration, at no extra cost, making our security setup more efficient.

What's Changing:

  • Better GitHub Fit: Direct integration with GitHub for security scans and dependency updates.
  • Free: Both tools are free, cutting costs.
  • Centralized Alerts: Findings now appear in the GitHub Security tab for easier management.

Quick Details:

  • CodeQL identifies vulnerabilities directly in the code.
  • Dependabot keeps our dependencies fresh and secure.

This update streamlines our security and dependency management, directly within GitHub.


You have dependabot and codeql already integrated :)

@scherersebastian
Copy link
Member Author

I also removed spotbugs workflow and config.
CodeQL covers static analysis for spotbugs / java.
Of course you can run both - it's your choice.

.github/workflows/codeql.yml Dismissed Show dismissed Hide dismissed
@scherersebastian
Copy link
Member Author

scherersebastian commented Feb 14, 2024

I removed your trivy workflow that scans the IaC analyze-config.
KICS does a better job at IaC scanning.
You do not need to run both.

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jzbmw
Copy link
Contributor

jzbmw commented Feb 15, 2024

@scherersebastian bevor the QQ Criteria are not updated, we will not approve this. Please make sure, that the QG Criteria for 24.03 and 24.05 are updated.

@scherersebastian
Copy link
Member Author

Interesting, I will take care of this.
Thanks for your feedback @jzbmw

ds-jhartmann added a commit that referenced this pull request Feb 22, 2024
@scherersebastian
Copy link
Member Author

scherersebastian commented Mar 4, 2024

Hello @jzbmw , I've reviewed our QGs. With Dependabot and CodeQL, we can successfully meet all QGs, serving as a replacement for Veracode (SCA, SAST). If this isn't clearly derived from the QGs, I'm happy to provide further feedback.

@ds-jhartmann ds-jhartmann merged commit d4cada7 into main Apr 5, 2024
13 of 15 checks passed
@ds-jhartmann ds-jhartmann deleted the ci/remove-veracode branch April 5, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants