Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/371 pi13 transfer to tractus x #685

Merged
merged 23 commits into from
Jun 19, 2024

Conversation

ds-jhartmann
Copy link
Contributor

@ds-jhartmann ds-jhartmann commented Jun 7, 2024

Description

  • Add cucumber feature files
  • Remove unused cucumber config and features
  • Refactor cucumber test workflows
  • Refactor tavern test workflows
  • Tavern and Cucumber Test reporting is done directly in GitHub
  • Add maven profiles for cucumber tests and dash license check

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ds-jhartmann ds-jhartmann linked an issue Jun 7, 2024 that may be closed by this pull request
9 tasks
Copy link

github-actions bot commented Jun 7, 2024

CHANGELOG file was not updated! Make sure to include important changes.

@ds-jhartmann
Copy link
Contributor Author

ds-jhartmann commented Jun 10, 2024

.github/workflows/tavern.yml Dismissed Show dismissed Hide dismissed
.github/workflows/tavern-integration.yml Dismissed Show dismissed Hide dismissed
.github/workflows/cucumber-integration-test.yaml Dismissed Show dismissed Hide dismissed
.github/workflows/cucumber-integration-test.yaml Dismissed Show dismissed Hide dismissed
Copy link

github-actions bot commented Jun 10, 2024

Test Results

56 tests   40 ✅  21m 46s ⏱️
 1 suites   0 💤
 1 files    16 ❌

For more details on these failures, see this check.

Results for commit 47a57ff.

♻️ This comment has been updated with latest results.

@ds-jhartmann ds-jhartmann marked this pull request as ready for review June 10, 2024 14:36
Copy link
Contributor

@dsmf dsmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ds-jhartmann pushed a commit to ds-jhartmann/item-relationship-service that referenced this pull request Jun 13, 2024
Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@dsmf dsmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ds-mwesener ds-mwesener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-jhartmann ds-jhartmann merged commit d77c6a1 into main Jun 19, 2024
16 of 22 checks passed
@ds-jhartmann ds-jhartmann deleted the feature/371-pi13-transfer-to-tractus-x branch June 19, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PI13] Transfer to Tractus-X
3 participants