Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/538 propagate exceptions via either and add suppressed #769

Merged
merged 22 commits into from
Jul 11, 2024
Merged

Fix/538 propagate exceptions via either and add suppressed #769

merged 22 commits into from
Jul 11, 2024

Conversation

ds-jhartmann
Copy link
Contributor

@ds-jhartmann ds-jhartmann commented Jul 8, 2024 •
edited
Loading

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

dsmf and others added 11 commits May 16, 2024 14:00
@dsmf
fix(impl): [#538] propagate exceptions to tombstones using Either and…
1cb33ca 
… addSuppressed
@dsmf
Update owasp.yml
db48632 
test
@dsmf
Merge branch 'main' into 538-propagate-exceptions-via-Either-and-addS…
9b01f6c 
…uppressed

# Conflicts:
#	irs-registry-client/src/test/java/org/eclipse/tractusx/irs/registryclient/central/CentralDigitalTwinRegistryServiceTest.java
@dsmf
Merge branch 'main' into 538-propagate-exceptions-via-Either-and-addS…
989244d 
…uppressed
@dsmf
Update irs-common/src/main/java/org/eclipse/tractusx/irs/common/util/…
e3c272a 
…concurrent/ResultFinder.java
@dsmf
Update irs-edc-client/src/main/java/org/eclipse/tractusx/irs/edc/clie…
e4d9216 
…nt/EdcSubmodelClientImpl.java
@ds-jhartmann
Merge pull request #737 from dsmf/538-propagate-exceptions-via-Either…
26eab7a 
…-and-addSuppressed

538 propagate exceptions via either and add suppressed
@ds-jhartmann
fix(registry-client):[#538] add rootCauses field in ErrorDetails to d…
12677d7 
…isplay suppressed exceptions in tombstones
@ds-jhartmann
fix(registry-client):[#538] add exception for case that no edc urls c…
aa23c8f 
…ould be discovered
@ds-jhartmann
Merge branch 'refs/heads/main' into fix/538-propagate-exceptions-via-…
a33e2c3 
…Either-and-addSuppressed
@ds-jhartmann
fix(registry-client):[#538] adjust openapi definition
4b752d5
@ds-jhartmann ds-jhartmann marked this pull request as ready for review July 9, 2024 10:05
@ds-jhartmann ds-jhartmann requested a review from dsmf July 10, 2024 07:15
@ds-jhartmann
Copy link
Contributor Author

Sonar Coverage report seems to be not correct, Classes are covered and most of them are for tests only

dsmf
dsmf approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@dsmf dsmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
52.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

ds-mwesener
ds-mwesener approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@ds-mwesener ds-mwesener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-mwesener ds-mwesener merged commit b5badde into main Jul 11, 2024
19 of 20 checks passed
@ds-mwesener ds-mwesener deleted the fix/538-propagate-exceptions-via-Either-and-addSuppressed branch July 11, 2024 08:53
@ds-jhartmann ds-jhartmann mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsmf dsmf dsmf approved these changes

@ds-mwesener ds-mwesener ds-mwesener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ds-jhartmann @dsmf @ds-mwesener