Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflows): replace hardcoded GH repo URL with variables #870

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

ds-jhartmann
Copy link
Contributor

@ds-jhartmann ds-jhartmann commented Aug 19, 2024

Description

  • replace hardcoded GH repo URL with variables
  • choose GH runner for umbrella tests dynamically, depending on the repo

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link

sonarcloud bot commented Aug 20, 2024

Copy link

Test Results

35 tests  +19   35 ✅ +34   5m 22s ⏱️ + 5m 21s
 1 suites ± 0    0 💤 ± 0 
 1 files   ± 0    0 ❌  - 15 

Results for commit de89ec8. ± Comparison against base commit cf0b76a.

This pull request removes 16 and adds 35 tests. Note that renamed tests count towards both.
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure first level supplier BPNL in investigation job with four level request has been detected correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure first level supplier BPNL in investigation job with several impacted nodes has been detected correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure first level supplier bpnl in investigation job with one level request has been detected correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure first level supplier bpnl in investigation job with three level request has been detected correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure investigation job for globalAssetId with missing BPNS in PartSiteInformationAsPlanned is processed correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure investigation job for globalAssetId with missing PartSiteInformationAsPlanned is processed correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure investigation job with invalid request is handled correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure investigation job with several relationships for valid globalAssetId and BPN is processed correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure investigation job with unknown globalAssetId and valid BPN is processed correctly
local.testing.api-tests.irs-ess-api-tests.tavern.yaml ‑ Make sure investigation job with valid globalAssetId and BPN is processed correctly
…
BomLifecycle 'asPlanned' implementation ‑ End 2 End for BomLifecycle 'asPlanned' Vehicle Model A for BMW [BPNL00000003AYRE]
BomLifecycle 'asPlanned' implementation ‑ End 2 End for BomLifecycle 'asPlanned' Vehicle Model B for MercedesBenz [BPNL00000003AYRE]
BomLifecycle 'asPlanned' implementation ‑ End 2 End for BomLifecycle 'asPlanned' Vehicle Model C for SAP [BPNL00000003AYRE]
IRS Batch Processing ‑ Check correct job executions of batch processing (SingleLevelBomAsBuilt/SerialPart 3.0.0)
IRS Policy Store ‑ Policy Store API:  Update a policy validUntil date for a policy that is associated to multiple BPNs
IRS Policy Store ‑ Policy Store API: Add BPN to policy
IRS Policy Store ‑ Policy Store API: Add policyId to given BPNs
IRS Policy Store ‑ Policy Store API: Delete policy for BPN
IRS Policy Store ‑ Policy Store API: Delete some policies
IRS Policy Store ‑ Policy Store API: Fetching policies by BPNLs should fail for invalid BPNLs (bad case)
…

Copy link
Contributor

@ds-lcapellino ds-lcapellino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-jhartmann ds-jhartmann merged commit 8207f2e into main Aug 22, 2024
18 checks passed
@ds-jhartmann ds-jhartmann deleted the chore/fix-vars-in-gh-workflows branch August 22, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants