Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to TX EDC 0.7 #92

Merged

Conversation

drcgjung
Copy link
Contributor

@drcgjung drcgjung commented Oct 20, 2023

WHAT

Upgrades Agent Plane(s) to TX EDC 0.7.0 (and Apache Jena 4.9)
Switches from full connector charts to data/agent plane only chart.

WHY

TX EDC 0.7.0 is the breaking-change release as of CX 24.05
Apache Jena has provided a new release which also updates quite some dependencies.
Having agent-plane only charts makes it easier for sidecar deployments with EDC.
Furthermore we can thus successfully test the data plane chart alone which should be now compliant to the TRGHs.
This PR has been aligned to the provider-part of the 24.05 E2E test

FURTHER NOTES

Closes #94
Closes #179
Closes #129
Closes #98
Closes #97
Closes #61
Closes #31
Closes #30
Closes #26
Closes #185

dependabot bot and others added 5 commits October 6, 2023 06:20
Bumps [docker/login-action](https://github.com/docker/login-action) from 2 to 3.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](docker/login-action@v2...v3)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [helm/chart-testing-action](https://github.com/helm/chart-testing-action) from 2.4.0 to 2.6.1.
- [Release notes](https://github.com/helm/chart-testing-action/releases)
- [Commits](helm/chart-testing-action@v2.4.0...v2.6.1)

---
updated-dependencies:
- dependency-name: helm/chart-testing-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.9.3 to 5.10.1.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.9.3...r5.10.1)

---
updated-dependencies:
- dependency-name: org.junit:junit-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
.github/workflows/build.yml Fixed Show fixed Hide fixed
.github/workflows/trivy.yml Fixed Show fixed Hide fixed
.github/workflows/helm-chart-lint.yml Fixed Show fixed Hide fixed
@drcgjung drcgjung marked this pull request as ready for review March 9, 2024 11:41
@drcgjung
Copy link
Contributor Author

drcgjung commented May 10, 2024

@almadigabor The chart linting actually should go through, see https://github.com/catenax-ng/tx-knowledge-agents-edc/actions/runs/9035264222 (where we have already integrated this PR) - sometimes helm does not "know" the standard repos as it seems when doing "cross-repo" actions. I tried to add the repos now explicitely.

However, the dependencies check will show the need to issue an IP check for the new versions of the depending modules, as Apache Jena https://github.com/catenax-ng/tx-knowledge-agents-edc/actions/runs/9035264223

maven/mavencentral/org.apache.httpcomponents/httpcore/4.4.16, Apache-2.0, approved, CQ23528
maven/mavencentral/org.apache.jena/jena-arq/4.9.0, Apache-2.0, restricted, clearlydefined
maven/mavencentral/org.apache.jena/jena-base/4.9.0, Apache-2.0, restricted, clearlydefined
maven/mavencentral/org.apache.jena/jena-core/4.9.0, Apache-2.0, restricted, clearlydefined
maven/mavencentral/org.apache.jena/jena-dboe-base/4.9.0, Apache-2.0, restricted, clearlydefined
maven/mavencentral/org.apache.jena/jena-dboe-index/4.9.0, Apache-2.0, restricted, clearlydefined
maven/mavencentral/org.apache.jena/jena-dboe-storage/4.9.0, Apache-2.0, restricted, clearlydefined
maven/mavencentral/org.apache.jena/jena-dboe-trans-data/4.9.0, Apache-2.0, restricted, clearlydefined
maven/mavencentral/org.apache.jena/jena-dboe-transaction/4.9.0, Apache-2.0, restricted, clearlydefined
maven/mavencentral/org.apache.jena/jena-fuseki-core/4.9.0, Apache-2.0, restricted, clearlydefined
maven/mavencentral/org.apache.jena/jena-rdfconnection/4.9.0, Apache-2.0, restricted, clearlydefined
maven/mavencentral/org.apache.jena/jena-rdfpatch/4.9.0, Apache-2.0, restricted, clearlydefined
maven/mavencentral/org.apache.jena/jena-shacl/4.9.0, Apache-2.0, restricted, clearlydefined
maven/mavencentral/org.apache.jena/jena-shex/4.9.0, Apache-2.0, restricted, clearlydefined
maven/mavencentral/org.apache.jena/jena-tdb/4.9.0, Apache-2.0, restricted, clearlydefined
maven/mavencentral/org.apache.jena/jena-tdb2/4.9.0, Apache-2.0, restricted, clearlydefined

It would be great if you could issue that IP check and review/commit this until the 15th (such that SAST can run until the 17th where the Q-Gates are).

Thx much!

@almadigabor
Copy link
Contributor

almadigabor commented May 14, 2024

Hi @drcgjung! I've ran the dash tool and got the following output:

[INFO] This content is either not correctly mapped by the system, or requires review.
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-base/4.9.0.
[INFO] A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14713 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-rdfpatch/4.9.0.
[INFO] A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14714 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-core/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14700 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-tdb2/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14701 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-fuseki-core/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14702 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-rdfconnection/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14703 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-dboe-storage/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14704 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-dboe-base/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14705 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-shacl/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14706 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-dboe-trans-data/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14707 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-tdb/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14708 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-shex/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14709 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-dboe-index/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14710 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-arq/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14711 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-dboe-transaction/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14712 .

Let's wait until the afternoon for these to be resolved then I can review and merge your PR. You might need a DEPENDENCIES file update once the IP issues are closed.

@almadigabor
Copy link
Contributor

Hey @drcgjung, can you update the dependencies file? If I see it correctly, all issues have been approved.

@drcgjung
Copy link
Contributor Author

Hey @drcgjung, can you update the dependencies file? If I see it correctly, all issues have been approved.

@almadigabor done and successful. thx.

@almadigabor
Copy link
Contributor

I opened an IP review issue due to the large number of changes. Please track the status here.

Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @drcgjung, see my comments below.

charts/agent-plane-azure-vault/templates/_helpers.tpl Outdated Show resolved Hide resolved
charts/agent-plane/templates/_helpers.tpl Outdated Show resolved Hide resolved
@drcgjung drcgjung requested a review from almadigabor May 16, 2024 10:43
@drcgjung
Copy link
Contributor Author

Again, the chart testing process somehow stuck but should be successful, if its been restarted: see https://github.com/catenax-ng/tx-knowledge-agents-edc/actions/runs/9138105951

@almadigabor
Copy link
Contributor

The IP check issue have been approved.

@almadigabor almadigabor merged commit 1d51fed into eclipse-tractusx:main May 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment