fix: null pointers in CustomAuthenticationConverter #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-gora
changed the title
borisrizov-zf
approved these changes
Nov 23, 2023
|
@m-gora Please run dash and submit any changes to A rebase before merging would be appreciated. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
Hehe no need to actually post the DEPENDENCIES contents. If they changed just commit them next time ;) |
|
@borisrizov-zf actually i thought synching the repos would perform a rebase but apparently didn't. |
|
🎉 This PR is included in version 0.2.0-develop.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.3.0-develop.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
borisrizov-zf
added a commit
that referenced
this pull request
Dec 7, 2023
* chore(helm): add a second maintainer * fix(ci): separate workflow "Test application (test + coverage)" for PR and repo Separate the one workflow into two single ones to avoid pipeline failure during report generation because of missing permissions. At the same time make all necessary/dependent changes to gradle.build and the Taskfile tasks. * chore(ci): remove doubled comment sign * chore(ci): adjust/remove step condition * chore(ci): extend name of step * chore(ci): rename steps for better understanding * chore(ci): replace deprecated properties * fix(dev): add file extension and refactor called method in gradle * chore(release): 0.2.0-develop.3 [skip ci] # [0.2.0-develop.3](v0.2.0-develop.2...v0.2.0-develop.3) (2023-11-22) ### Bug Fixes * **ci:** separate workflow "Test application (test + coverage)" for PR and repo ([6de785b](6de785b)) * **dev:** add file extension and refactor called method in gradle ([6811a8b](6811a8b)) * feat: add tpl to miw ingress (#143) Co-authored-by: Dominik Pinsel <dominik.pinsel@mercedes-benz.com> * chore(release): 0.2.0-develop.4 [skip ci] # [0.2.0-develop.4](v0.2.0-develop.3...v0.2.0-develop.4) (2023-11-22) ### Features * add tpl to miw ingress ([#143](#143)) ([c56d133](c56d133)) * feat(helm): Make liveness & readiness probes configurable (#99) * feat(helm): Make liveness & readiness probes configurable * Add possibility to disable probes * Update chart README.md * add examples to ingress config * Bump chart version * Update README.md * Add workflow step for checking chart readme changed * Fix readme generation * Add some names to the worflow steps * Rename workflow * Update chart README.md * chore(release): 0.2.0-develop.5 [skip ci] # [0.2.0-develop.5](v0.2.0-develop.4...v0.2.0-develop.5) (2023-11-22) ### Features * **helm:** Make liveness & readiness probes configurable ([#99](#99)) ([252eed1](252eed1)) * feat: add initContainers (#142) * feat: add initContainers * chore: add initContainer description * fix: only template initContainer if present * chore: use tpl instead common to render initContianers As from pmoscode suggested the tpl function can be used with toYaml to avoid the Bitnami common template function. --------- Co-authored-by: Dominik Pinsel <dominik.pinsel@mercedes-benz.com> * chore(release): 0.2.0-develop.6 [skip ci] # [0.2.0-develop.6](v0.2.0-develop.5...v0.2.0-develop.6) (2023-11-23) ### Features * add initContainers ([#142](#142)) ([7317800](7317800)) * feat(dev): add pgAdmin to local dev env (#144) Additions and Changes: - add pgAdmin to docker-compose.yaml (incl. mounts) - preconfigure pgAdmin DB server - add tem. files to gitignore - update README.md - update Taskfile tasks for linux and macos - update env.* environment files - Match Postgresql version to the version of the Helm chart (14.5) * chore(release): 0.2.0-develop.7 [skip ci] # [0.2.0-develop.7](v0.2.0-develop.6...v0.2.0-develop.7) (2023-11-23) ### Features * **dev:** add pgAdmin to local dev env ([#144](#144)) ([d7f2bbe](d7f2bbe)) * chore: update SECURITY.md (#170) Make SECURITY.md reflect current example of TRG 7.01 pointing to the GitHub Security Tab instead of Eclipse * docs: draft for report of security assessment 23.12 * feat(devel): make application port dynamic (parameter) * feat(readme): add "usage" section [WIP] * fix(dev): adjust port to request against keycloak * feat(dev): update README.md and introduce INSTALL.md for usage * fix(dev): add important notes to INSTALL.md * fix(dev): small adjustment to INSTALL.md * chore(release): 0.2.0-develop.8 [skip ci] # [0.2.0-develop.8](v0.2.0-develop.7...v0.2.0-develop.8) (2023-11-28) ### Bug Fixes * **dev:** add important notes to INSTALL.md ([a7c1b71](a7c1b71)) * **dev:** adjust port to request against keycloak ([4a3d317](4a3d317)) * **dev:** small adjustment to INSTALL.md ([59b6df4](59b6df4)) ### Features * **devel:** make application port dynamic (parameter) ([8816c89](8816c89)) * **dev:** update README.md and introduce INSTALL.md for usage ([54b8d4a](54b8d4a)) * **readme:** add "usage" section [WIP] ([6919b71](6919b71)) * fix: method name from the cx-ssi-lib has been renamed * chore: remove unused maven repo from gradle config * chore: remove unused GITHUB_USERNAME/TOKEN env variables * chore: remove cx-ssi-lib from NOTICE * chore: update DEPENDENCIES scan * chore(release): 0.2.0-develop.9 [skip ci] # [0.2.0-develop.9](v0.2.0-develop.8...v0.2.0-develop.9) (2023-11-30) ### Bug Fixes * method name from the cx-ssi-lib has been renamed ([b46d084](b46d084)) * fix null pointers in CustomAuthenticationConverter (#169) * fix:seperate api doc from DidDocumentController * fix:change bpn to identifier * fix:seperate docs from controller * fix:change bpn to identifier * fix:seperate api docs * fix:seperate api docs * fix:change bpn to identifier * fix:seperate half of the docs * fix:add one more seperation * fix:seperate docs * chore: update spring-boot and testcontainers * chore: add resolutionStrategy for logback and spring devtools * chore: update cx-ssi-lib to 0.0.18 * chore: update DEPENDENCIES with Dash * fix: manually change the Helm chart version The automated pipeline is failing, because the develop.9 version has been published to the gh-pages branch. A manual change to develop.10 should fix the issue. * chore(release): 0.2.0-develop.10 [skip ci] # [0.2.0-develop.10](v0.2.0-develop.9...v0.2.0-develop.10) (2023-12-05) ### Bug Fixes * manually change the Helm chart version ([1ad16ed](1ad16ed)) * chore: add legal files to Docker * chore: update DEPENDENCIES with Dash * fix: remove filter for org.eclipse packages This filtering was in violation with TRG 7.01. * chore: update DEPENDENCIES with Dash * chore(release): 0.2.0-develop.11 [skip ci] # [0.2.0-develop.11](v0.2.0-develop.10...v0.2.0-develop.11) (2023-12-06) ### Bug Fixes * remove filter for org.eclipse packages ([af9a9e5](af9a9e5)) * chore: update Version and AppVersion in chart readme * chore: supply correct version in chart readme * chore(release): 0.3.0-develop.1 [skip ci] # [0.3.0-develop.1](v0.2.0...v0.3.0-develop.1) (2023-12-07) ### Bug Fixes * **ci:** separate workflow "Test application (test + coverage)" for PR and repo ([6de785b](6de785b)) * **dev:** add file extension and refactor called method in gradle ([6811a8b](6811a8b)) * **dev:** add important notes to INSTALL.md ([a7c1b71](a7c1b71)) * **dev:** adjust port to request against keycloak ([4a3d317](4a3d317)) * **dev:** small adjustment to INSTALL.md ([59b6df4](59b6df4)) * manually change the Helm chart version ([1ad16ed](1ad16ed)) * method name from the cx-ssi-lib has been renamed ([b46d084](b46d084)) * remove filter for org.eclipse packages ([af9a9e5](af9a9e5)) ### Features * add initContainers ([#142](#142)) ([7317800](7317800)) * add tpl to miw ingress ([#143](#143)) ([c56d133](c56d133)) * **dev:** add pgAdmin to local dev env ([#144](#144)) ([d7f2bbe](d7f2bbe)) * **devel:** make application port dynamic (parameter) ([8816c89](8816c89)) * **dev:** update README.md and introduce INSTALL.md for usage ([54b8d4a](54b8d4a)) * **helm:** Make liveness & readiness probes configurable ([#99](#99)) ([252eed1](252eed1)) * **readme:** add "usage" section [WIP] ([6919b71](6919b71)) --------- Co-authored-by: Peter Motzko <peter.motzko@volkswagen.de> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Marco Lecheler <marco@task.media> Co-authored-by: Dominik Pinsel <dominik.pinsel@mercedes-benz.com> Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <florian.rusch.external@zf.com> Co-authored-by: Peter Motzko <56410761+pmoscode@users.noreply.github.com> Co-authored-by: Pablo <103579938+pablosec@users.noreply.github.com> Co-authored-by: pablosec <pablo.theissen@telekom.de> Co-authored-by: Marco Gora <blackanthrax666@googlemail.com> Co-authored-by: Mustafa <mmsalfiti@gmail.com>
|
🎉 This PR is included in version 0.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
proper pull request in place of #137
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: