Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/security finding #277

Closed

Conversation

thackerronak
Copy link
Contributor

@thackerronak thackerronak commented Mar 28, 2024

Description

Spring boot and cloud lib version was updated to mitigate GHSA-f3jh-qvm4-mg39

Note:
Below are two dependencies showing restricted which need to be fixed in ssi-lib.
maven/mavencentral/org.jetbrains.kotlin/kotlin-stdlib-jdk7/1.9.23, None, restricted, #14188
maven/mavencentral/org.jetbrains.kotlin/kotlin-stdlib-jdk8/1.9.23, None, restricted, #14185

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@borisrizov-zf
Copy link
Contributor

@thackerronak Hi, we cannot merge a PR which includes "restricted" dependencies. You also mentioned that this has to do with the SSI lib. Can you elaborate?

Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@thackerronak
Copy link
Contributor Author

@thackerronak Hi, we cannot merge a PR which includes "restricted" dependencies. You also mentioned that this has to do with the SSI lib. Can you elaborate?

@borisrizov-zf I have updated the DEPENDENCIES file and found that all dependencies are showing approved.

Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nitin-vavdiya
Copy link
Contributor

@thackerronak Please rebase and re-generate DEPENDENCIES

@nitin-vavdiya
Copy link
Contributor

nitin-vavdiya commented Jul 22, 2024

@thackerronak please rebase and re-generate DEPENDENCIES

Also, change target branch to develop

@nitin-vavdiya nitin-vavdiya self-requested a review July 22, 2024 06:51
@thackerronak thackerronak deleted the fix/security-finding branch July 22, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants