Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: policy hub post get policy rules response structuring error value map #201

Conversation

leandro-cavalcante
Copy link
Contributor

Description

Enhanced the filter GET/POST for policyContent end point

Why

The current implementation of the GET/POST endpoint in the Policy Hub does not respond as expected when fetching a policy based on specific criteria

Issue

N/a

Checklist

Please delete options that are not relevant.

  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes

@MaximilianHauer MaximilianHauer requested review from Phil91 and ntruchsess and removed request for Phil91 September 18, 2024 07:11
@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Sep 18, 2024
@Phil91
Copy link
Member

Phil91 commented Sep 18, 2024

@leandro-cavalcante out of curiosity, could you provide a request that was failing?

@leandro-cavalcante
Copy link
Contributor Author

@Phil91 Yes, now when the value is not present in the DB an exception Is thrown. I.e:
image

@Phil91 Phil91 self-assigned this Sep 19, 2024
@Phil91 Phil91 merged commit b5a1ec3 into eclipse-tractusx:main Sep 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants