Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove picture references to user-images #243

Conversation

johanneskueffner
Copy link
Contributor

@johanneskueffner johanneskueffner commented Feb 2, 2024

Description

  • add pictures to docs static
  • link pictures from docs static
  • add picture guidlines to contributing guide

Why

Cleanup

Issue

Link to Github issue.

Checklist

  • I have followed the contributing guidelines
  • I have added copyright and license headers, footers (for .md files) or files (for images)
  • I have performed a self-review of my own changes

@johanneskueffner johanneskueffner changed the base branch from main to release/v1.8.0-RC4 February 2, 2024 14:35
@johanneskueffner johanneskueffner changed the title Chore: remove picture references to catenax-ng chore: remove picture references to catenax-ng Feb 2, 2024
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!
Just have a look at my comment

And please also add the following as the issue requests:
"Please also enhance the 'How to contribute' guide with a description about how to manage images (upload to static/docs, create license file, link in the documentation...)."

And correct the PR title, I think you wanted to write user-images instead of catenax-ng.

@johanneskueffner johanneskueffner changed the title chore: remove picture references to catenax-ng chore: remove picture references to userfiles Feb 8, 2024
@johanneskueffner johanneskueffner changed the title chore: remove picture references to userfiles chore: remove picture references to user-images Feb 9, 2024
@jjeroch jjeroch added the merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled label Feb 11, 2024
@jjeroch
Copy link
Contributor

jjeroch commented Feb 11, 2024

Hi, before merging we need to validate what we merge first - in parallel following prs got created and might impact this pr

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarcloud bot commented Feb 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@evegufy
Copy link
Contributor

evegufy commented Feb 12, 2024

Hi, before merging we need to validate what we merge first - in parallel following prs got created and might impact this pr

I'll merge this PR first and then solve potential conflicts and do the necessary adjustments for the mentioned PRs.

@evegufy evegufy merged commit dd014b5 into eclipse-tractusx:release/v1.8.0-RC4 Feb 12, 2024
6 checks passed
@evegufy evegufy deleted the chore/remove-user-images branch February 12, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants