fix(bpdm): allow null values for geographic coordinate altitude (#882)

* fix(bpdm): allow null values for geographic coordinate altitude Null altitude breaks onboarding. Refs: #881
eclipse-tractusx · Aug 1, 2024 · 7825b1b · 7825b1b
1 parent cb0715a
commit 7825b1b
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/externalsystems/Bpdm.Library/Models/BpdmAddressDto.cs b/src/externalsystems/Bpdm.Library/Models/BpdmAddressDto.cs
@@ -94,5 +94,5 @@ BpdmDataDto Language
 public record BpdmGeographicCoordinatesDto(
     double Longitude,
     double Latitude,
-    double Altitude
+    double? Altitude
 );
diff --git a/src/externalsystems/Bpdm.Library/Models/BpdmLegalEntityData.cs b/src/externalsystems/Bpdm.Library/Models/BpdmLegalEntityData.cs
@@ -36,7 +36,7 @@ string Type
 public record BpdmGeographicCoordinates(
     double Longitude,
     double Latitude,
-    double Altitude
+    double? Altitude
 );
 
 public record BpdmPutStreet(

diff --git a/tests/externalsystems/Bpdm.Library/BPNAccessTest.cs b/tests/externalsystems/Bpdm.Library/BPNAccessTest.cs
@@ -136,7 +136,7 @@ public async Task FetchLegalEntityByBpn_Success_ReturnsExpected()
                     ""geographicCoordinates"": {
                         ""longitude"": 0.0,
                         ""latitude"": 0.0,
-                        ""altitude"": 0.0
+                        ""altitude"": null
                     },
                     ""country"": {
                         ""technicalKey"": ""DE"",

diff --git a/tests/externalsystems/Bpdm.Library/BpdmServiceTests.cs b/tests/externalsystems/Bpdm.Library/BpdmServiceTests.cs
@@ -361,7 +361,7 @@ public async Task FetchInputLegalEntity_WithValidResult_ReturnsExpected()
                         ""geographicCoordinates"": {
                             ""longitude"": 0,
                             ""latitude"": 0,
-                            ""altitude"": 0
+                            ""altitude"": null
                         },
                         ""country"": ""UNDEFINED"",
                         ""administrativeAreaLevel1"": ""string"",