Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daps): remove daps #183

Merged

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Aug 3, 2023

Description

remove the daps service including all calls to daps
remove daps from business logic
remove assigned offersubscriptions from connector when deleting the connector

Why

Daps Service is not supported anymore.

Issue

N/A - Jira Issue: CPLP-3105

Corresponding CD PR

#59

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 requested a review from ntruchsess August 3, 2023 13:56
@jjeroch jjeroch added rel 1.6.0 priority PR needs to prioritized at review labels Aug 3, 2023
@Phil91 Phil91 marked this pull request as ready for review August 3, 2023 19:14
Phil91 and others added 3 commits August 4, 2023 09:23
remove the daps service including all calls to daps
remove daps from business logic

Refs: CPLP-3105
remove assigned offersubscriptions from connector when deleting the connector

Refs: CPLP-3105
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Phil91 Phil91 merged commit d73c9f2 into eclipse-tractusx:release/v1.6.0-RC5 Aug 4, 2023
5 checks passed
@Phil91 Phil91 deleted the feature/CPLP-3105-daps branch August 4, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PR needs to prioritized at review rel 1.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants