Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registration) : update dateLastChange companyApplication #307

Conversation

VPrasannaK94
Copy link
Contributor

Description

update dateLastChange of companyApplication

Why

update dateLastChange of companyApplication for some endpoints in registrationService

Issue

N/A Ref : CPLP-3313

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@VPrasannaK94 VPrasannaK94 marked this pull request as ready for review October 18, 2023 05:45
Copy link
Member

@Phil91 Phil91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one Endpoint not yet adjusted that was mentioned in the ticket:

DELETE /api/registration/documents/{documentId}

@Phil91 Phil91 self-assigned this Oct 18, 2023
@Phil91
Copy link
Member

Phil91 commented Oct 18, 2023

There is one Endpoint not yet adjusted that was mentioned in the ticket:

DELETE /api/registration/documents/{documentId}

-> did overlook the implementation - endpoint done

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Phil91 Phil91 merged commit 836e01b into eclipse-tractusx:dev Oct 19, 2023
6 checks passed
@Phil91 Phil91 deleted the feature/CPLP-3313-update-dateLastChange-companyApplication branch October 19, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants