Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(worker): add new business process workers #345

Merged
merged 16 commits into from
Mar 15, 2024
Merged

feat(worker): add new business process workers #345

merged 16 commits into from
Mar 15, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Nov 21, 2023 •
edited
Loading

Description

add worker for invitation
add mailing worker

Why

Currently if the sending of a mail fails the user receives an error although the request itself was successful. Therefore the mail sending was moved to an process.

Issue

N/A - Jira Issue: CPLP-3383

Corresponding CD PR

#127

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 force-pushed the feature/CPLP-3383-worker branch 3 times, most recently from 6999323 to a0041b4 Compare November 22, 2023 15:47
@Phil91 Phil91 marked this pull request as ready for review November 22, 2023 15:58
This was referenced Nov 22, 2023
Closed
Merged
@Phil91 Phil91 force-pushed the feature/CPLP-3383-worker branch 2 times, most recently from 0d92edc to 11636da Compare December 1, 2023 09:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@ntruchsess ntruchsess force-pushed the feature/CPLP-3383-worker branch 2 times, most recently from 996e526 to 26318d7 Compare January 8, 2024 18:00
@Phil91 Phil91 requested a review from ntruchsess January 9, 2024 15:10
ntruchsess
ntruchsess requested changes Jan 10, 2024
View reviewed changes
src/externalsystems/Provisioning.Library/IdpManagement.cs Outdated Show resolved Hide resolved
src/externalsystems/Provisioning.Library/IdpManagement.cs Show resolved Hide resolved
src/keycloak/Keycloak.Library/Models/IdentityProviders/IdentityProvider.cs Outdated Show resolved Hide resolved
src/keycloak/Keycloak.Library/Models/RealmsAdmin/Realm.cs Outdated Show resolved Hide resolved
src/processes/Invitation.Executor/InvitationProcessService.cs Outdated Show resolved Hide resolved
src/processes/Invitation.Executor/InvitationProcessTypeExecutor.cs Outdated Show resolved Hide resolved
src/processes/NetworkRegistration.Library/NetworkRegistrationHandler.cs Outdated Show resolved Hide resolved
src/registration/ApplicationActivation.Library/ApplicationActivationService.cs Outdated Show resolved Hide resolved
@Phil91 Phil91 force-pushed the feature/CPLP-3383-worker branch 3 times, most recently from 546cce4 to e43dd6c Compare January 11, 2024 12:41
@Phil91 Phil91 added this to the CX Release 24.03 milestone Jan 17, 2024
@Phil91 Phil91 changed the base branch from dev to release/v1.8.0-RC2 January 17, 2024 11:34
@Phil91 Phil91 removed this from the CX Release 24.03 milestone Jan 17, 2024
@Phil91 Phil91 changed the base branch from release/v1.8.0-RC2 to dev January 17, 2024 11:34
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
1.6% Duplication on New Code

See analysis details on SonarCloud

@jjeroch jjeroch added this to the Version CX Release 24.05 (dev) milestone Feb 4, 2024
ntruchsess
ntruchsess requested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@ntruchsess ntruchsess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please first fix the conflicts

@jjeroch jjeroch added the priority PR needs to prioritized at review label Mar 8, 2024
@ntruchsess ntruchsess force-pushed the feature/CPLP-3383-worker branch 11 times, most recently from 96861c7 to 2059e52 Compare March 13, 2024 10:23
@ntruchsess ntruchsess force-pushed the feature/CPLP-3383-worker branch 3 times, most recently from 035896f to 2711634 Compare March 14, 2024 13:44
@ntruchsess ntruchsess force-pushed the feature/CPLP-3383-worker branch 3 times, most recently from 9c5caf6 to 4a5a53c Compare March 14, 2024 14:41
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
9 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess merged commit 0c6aeb2 into eclipse-tractusx:dev Mar 15, 2024
8 checks passed
@ntruchsess ntruchsess deleted the feature/CPLP-3383-worker branch March 15, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

Assignees
No one assigned
Labels
priority PR needs to prioritized at review
Projects
None yet
Milestone
Release 2.0.0 (24.05)
Development

Successfully merging this pull request may close these issues.
3 participants
@Phil91 @ntruchsess @jjeroch