feat(process): slimline process identity config

[Phil91]

Description

All configuration values needed for the process identity were removed except for the identity id.

Why

The determination of the identity needed for the process worker is now done with a database request to get the needed values for the specified user.

Issue

N/A - Jira Issue: CPLP-3102

Corresponding CD PR

#130

Checklist

• I have followed the contributing guidelines
• I have performed a self-review of my own code
• I have successfully tested my changes locally
• I have added tests that prove my changes work
• I have checked that new and existing tests pass locally with my changes
• I have commented my code, particularly in hard-to-understand areas

[ntruchsess]

the ! in when !Guid.TryParse looks incorrect. We should have a unit-test for the method TransformAsync

instead of the cumbersome switch / case that somewhat hides the actual flow of information I recommend a more traditional implementation:

private async ValueTask<bool> AddIdentity(ClaimsPrincipal principal, ClaimsIdentity claimsIdentity)
{
    var preferredUserName = principal.Claims.SingleOrDefault(x => x.Type == PortalClaimTypes.PreferredUserName)?.Value;

    if (!string.IsNullOrWhiteSpace(preferredUserName) && Guid.TryParse(preferredUserName, out var identityId))
    {
        claimsIdentity.AddClaim(new Claim(PortalClaimTypes.IdentityId, identityId.ToString()));
        return true;
    }

    var sub = principal.Claims.SingleOrDefault(x => x.Type == PortalClaimTypes.Sub)?.Value;
    _logger.LogInformation("Preferred user name {PreferredUserName} couldn't be parsed to uuid for userEntityId {Sub}", preferredUserName, sub);

    IdentityData? identityData;
    if (string.IsNullOrWhiteSpace(sub) || (identityData = await _portalDbRepositories.GetInstance<IUserRepository>().GetActiveUserDataByUserEntityId(sub).ConfigureAwait(false)) == null)
    {
        _logger.LogWarning("No identity found for userEntityId {Sub}", sub);
        return false;
    }

    claimsIdentity.AddClaim(new Claim(PortalClaimTypes.IdentityId, identityData.UserId.ToString()));
    return true;
}

[Phil91]

I did change the implementation and added unit tests.

[ntruchsess]

sonar marks this as a code smell. According to the smell's documentation it should accept
public Guid IdentityId => (_identityId ?? (_identityId = _httpContextAccessor.HttpContext?.User.GetIdentityId()))!.Value;
(I guess the rule doesn't yet know about the ??= operator, so maybe we should just mark this as a false positive?)

[Phil91]

I'd mark it as a false positive

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication