Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add pr linting #375

Merged
merged 1 commit into from
Dec 5, 2023
Merged

chore: add pr linting #375

merged 1 commit into from
Dec 5, 2023

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Dec 5, 2023

Description

add linting workflow to check for conventional commit pull requests

Why

To make sure the coding guidelines are met

Issue

N/A

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 requested a review from evegufy December 5, 2023 15:36
@Phil91 Phil91 marked this pull request as ready for review December 5, 2023 15:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Phil91 Phil91 merged commit ecc3a91 into release/v1.7.0 Dec 5, 2023
5 checks passed
@Phil91 Phil91 deleted the feature/changelog branch December 5, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evegufy evegufy evegufy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Phil91 @evegufy