Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(name): Wrong name property value #380

Conversation

AnuragNagpure
Copy link
Contributor

@AnuragNagpure AnuragNagpure commented Dec 12, 2023

Description

Return clientClientId instead of the serviceAccount name for endpoint: GET /api/Services/{serviceId}/subscription/{subscriptionID}/provider

Why

the service account name is getting responded

Issue

N/A - Jira Ref: CPLP-3505

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91
Copy link
Member

Phil91 commented Dec 12, 2023

@AnuragNagpure please have a look at the unit tests the workflow currently is failing. I think it might be to the adjusted test seeding. Best would be to run all unit tests once before pushing

@Phil91 Phil91 self-assigned this Dec 12, 2023
Copy link

sonarcloud bot commented Dec 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@Phil91 Phil91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnuragNagpure fyi i've updated the pr description, please have a look at it.

@Phil91 Phil91 merged commit d20c582 into eclipse-tractusx:dev Dec 12, 2023
7 checks passed
@Phil91 Phil91 deleted the bug/CPLP-3505-provider-wrong-property-value branch December 12, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants