feat(osp): endpoint to get onboarding osp companies details #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...s/administration/Administration.Service.Tests/BusinessLogic/RegistrationBusinessLogicTest.cs
Fixed
Show fixed
Hide fixed
...s/administration/Administration.Service.Tests/BusinessLogic/RegistrationBusinessLogicTest.cs
Fixed
Show fixed
Hide fixed
...s/administration/Administration.Service.Tests/BusinessLogic/RegistrationBusinessLogicTest.cs
Fixed
Show fixed
Hide fixed
sure will directing to release branch |
|
@AnuragNagpure please rebase to release/v2.1.0-RC2 and make sure you synched to the latest version before. it seems like there are 8 commits in that shouldn't be in |
AnuragNagpure
force-pushed
the
feature/808-get-endpoint-for-onboarding-osp-details
branch
from
e7e5f8a
to
26d3f35
Compare
ntruchsess
force-pushed
the
feature/808-get-endpoint-for-onboarding-osp-details
branch
from
26d3f35
to
0c576f6
Compare
|
I just removed the unwanted commits by doing an interactive rebase |
ntruchsess
force-pushed
the
feature/808-get-endpoint-for-onboarding-osp-details
branch
from
c66e151
to
4c1cde0
Compare
ntruchsess
previously approved these changes
Jul 25, 2024
|
I did fix all of my review-findings |
evegufy
requested changes
Jul 25, 2024
Phil91
previously approved these changes
Jul 26, 2024
|
confirmed: v.2.1.0 is closed, please change to main |
evegufy
dismissed stale reviews from Phil91 and ntruchsess
The base branch was changed.
Phil91
requested changes
Jul 30, 2024
| application.Company.CompanyAssignedRoles.Select(companyAssignedRoles => companyAssignedRoles.CompanyRoleId), | ||
| application.Company.IdentityProviders.Select(x => new IdentityProvidersDetails(x.Id, x.IamIdentityProvider!.IamIdpAlias)), | ||
| application.Company.BusinessPartnerNumber, | ||
| application.Company.Identities.Where(x => x.CompanyUser!.Identity!.UserStatusId != UserStatusId.DELETED).Count())) |
There was a problem hiding this comment.
This can be changed to
Suggested change
| application.Company.Identities.Where(x => x.CompanyUser!.Identity!.UserStatusId != UserStatusId.DELETED).Count())) | |
| application.Company.Identities.Count(x => x.CompanyUser!.Identity!.UserStatusId != UserStatusId.DELETED))) |
AnuragNagpure
force-pushed
the
feature/808-get-endpoint-for-onboarding-osp-details
branch
from
21106a6
to
919203f
Compare
|
Phil91
approved these changes
Jul 31, 2024
|
@evegufy can you please approve that we can merge. |
evegufy
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why
Need this api to retrieve a list of all Onboarded OSP (Onboarding Service Provider) companies along with their current ### status
Issue
#808
Checklist
Please delete options that are not relevant.