Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): adjust sd doc validation for connector creation #894

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jul 31, 2024

Description

Skip the validation for an existing sd document if the clearinghouse connect is disabled

Why

To fix the exception which is thrown when creating a connector if a company has been onboarded with the flag ClearinghouseConnectDisabled set to true.

Issue

Refs: #887

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

Copy link

sonarcloud bot commented Aug 5, 2024

@Phil91 Phil91 merged commit b38390e into main Aug 6, 2024
11 checks passed
@Phil91 Phil91 deleted the bugfix/887-connector branch August 6, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sig#796: Connector registration fails if clearinghouseConnectDisabled gets disabled after onboarding
3 participants