Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): adjust create notification endpoint #906

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Aug 8, 2024

Description

Adjust the create notification request type

Why

The request parameter should be receiver instead of requester, since it is the person who receives the notification

Issue

Refs: #812

Corresponding SSI PR

eclipse-tractusx/ssi-credential-issuer#233

Corresponding Iam PR

eclipse-tractusx/portal-iam#169

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

Copy link

sonarcloud bot commented Aug 8, 2024

@ntruchsess ntruchsess linked an issue Aug 14, 2024 that may be closed by this pull request
@Phil91 Phil91 merged commit 0823e2d into main Aug 14, 2024
11 checks passed
@Phil91 Phil91 deleted the feature/812-create-notification branch August 14, 2024 08:24
Phil91 added a commit to AnuragNagpure/portal-backend that referenced this pull request Sep 6, 2024
…tusx#906)

Refs: eclipse-tractusx#812
Reviewed-By: Norbert Truchsess <norbert.truchsess@t-online.de>
@Phil91 Phil91 added this to the Release 24.12 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

Cleanup - Notification Endpoints
2 participants