Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BPDM): fixed the request structure of BPDM api #928

Conversation

dhiren-singh-007
Copy link
Contributor

Description

Renamed the property OwnCompanyData to IsOwnCompanyData as per BPDM api specifications

Why

BPDM was having issues as this flag IsOwnCompanyData was always false as Portal was sending wrong flag

Issue

#927

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have checked that new and existing tests pass locally with my changes

Copy link

sonarcloud bot commented Aug 14, 2024

@ybidois
Copy link

ybidois commented Aug 14, 2024

@MaximilianHauer This is a very small bug to fix but it is very beneficial to the BPDM team. With this, BPDM can correctly identify the Catena-X members when we send records. Could you prioritize this ticket?

CC: @maximilianong @Sebastian-Wurm @nicoprow

@Phil91 Phil91 merged commit 7286027 into eclipse-tractusx:release/v2.2.0-RC2 Aug 14, 2024
11 checks passed
@dhiren-singh-007 dhiren-singh-007 deleted the bugfix/927-fix-bpdm-request branch August 14, 2024 09:47
@Phil91 Phil91 added this to the Release 2.2.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants