Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(invitation): allow access to invitation endpoint to technical user #933

Conversation

typecastcloud
Copy link
Contributor

@typecastcloud typecastcloud commented Aug 14, 2024

Description

Allow access to invitation endpoint to technical user.

Why

Technical user/clients were not able to use endpoint.

Issue

Refs: #932

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have checked that new and existing tests pass locally with my changes

@Phil91 Phil91 changed the base branch from release/v2.2.0-RC2 to release/v2.2.0-RC3 August 14, 2024 15:42
@Phil91 Phil91 added this to the Release 2.2.0 milestone Aug 14, 2024
@typecastcloud typecastcloud force-pushed the feat/allow-invitation-access-for-technical-users branch from 4ab2608 to fcea7eb Compare August 15, 2024 09:59
@Phil91 Phil91 added the merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled label Aug 21, 2024
@Phil91 Phil91 changed the base branch from release/v2.2.0-RC3 to release/v2.2.0-RC4 August 30, 2024 05:38
@Phil91
Copy link
Member

Phil91 commented Sep 2, 2024

@typecastcloud please update the dependencies. can be found in the artefacts here: https://github.com/eclipse-tractusx/portal-backend/actions/runs/10402110437?pr=933

@typecastcloud typecastcloud force-pushed the feat/allow-invitation-access-for-technical-users branch from fcea7eb to 070cb92 Compare September 4, 2024 07:42
@typecastcloud
Copy link
Contributor Author

typecastcloud commented Sep 4, 2024

@typecastcloud please update the dependencies. can be found in the artefacts here: https://github.com/eclipse-tractusx/portal-backend/actions/runs/10402110437?pr=933

Hi @Phil91, I rebased to release/v2.2.0-RC4 branch. Tests are failing on that branch. Not sure if that also resolved dependencies.

@Phil91 Phil91 changed the base branch from release/v2.2.0-RC4 to release/v2.2.0-RC5 September 10, 2024 10:59
@evegufy
Copy link
Contributor

evegufy commented Sep 10, 2024

Hi @typecastcloud I suggest to do an interactive rebase dropping all commits that aren't yours

Technical user/clients were now able to use endpoint.

Refs: eclipse-tractusx#932
@typecastcloud typecastcloud force-pushed the feat/allow-invitation-access-for-technical-users branch from 070cb92 to ed47439 Compare September 10, 2024 12:22
@typecastcloud
Copy link
Contributor Author

Hi @typecastcloud I suggest to do an interactive rebase dropping all commits that aren't yours

Done. Rebased on RC5. Not sure why this PR wants updated dependencies.

@typecastcloud
Copy link
Contributor Author

typecastcloud commented Sep 10, 2024

@evegufy I also updated dependencies now

I didn't notice that this was considered for 2.2.0.

@Phil91
Copy link
Member

Phil91 commented Sep 10, 2024

@MaximilianHauer should this be included in the 2.2.0 release?

@evegufy
Copy link
Contributor

evegufy commented Sep 10, 2024

@evegufy I also updated dependencies now

I didn't notice that this was considered for 2.2.0.

@typecastcloud I didn't question the base branch up to now but yes, I'd prefer to move it to main, not to 2.2.0.

cc: @Phil91 @MaximilianHauer

@evegufy evegufy changed the base branch from release/v2.2.0-RC5 to main September 10, 2024 14:38
@evegufy evegufy modified the milestones: Release 2.2.0, Release 24.12 Sep 10, 2024
Copy link

sonarcloud bot commented Sep 10, 2024

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaximilianHauer could you please review as well?

@evegufy
Copy link
Contributor

evegufy commented Sep 12, 2024

@MaximilianHauer could you please review as well?

Just saw #932 (comment)

@evegufy evegufy merged commit 444a8ab into eclipse-tractusx:main Sep 12, 2024
11 checks passed
@typecastcloud
Copy link
Contributor Author

@MaximilianHauer could you please review as well?

Just saw #932 (comment)

I'll create a separate PR for this since it requires more complex additions to the code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants