Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(invite): create application and company on invite #960

Merged
merged 4 commits into from
Sep 17, 2024
Merged

feat(invite): create application and company on invite #960

merged 4 commits into from
Sep 17, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Aug 29, 2024

Description

moved the creation of the company and company application to the invite business logic to directly create them with the invite.

Why

to remove the delay of the company application after invite

Issue

Refs: #700

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 requested review from ntruchsess and evegufy and removed request for ntruchsess August 29, 2024 11:32
@Phil91 Phil91 added this to the Release 24.12 milestone Aug 29, 2024
@Phil91 Phil91 requested a review from ntruchsess August 29, 2024 11:32
@dhiren-singh-007 dhiren-singh-007 mentioned this pull request Sep 5, 2024
Closed
ntruchsess
ntruchsess requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@ntruchsess ntruchsess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@ntruchsess ntruchsess linked an issue Sep 17, 2024 that may be closed by this pull request
Invite Service - Delay in displaying application record after company invite #700
Closed
@ntruchsess ntruchsess self-assigned this Sep 17, 2024
ntruchsess
ntruchsess previously approved these changes Sep 17, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess merged commit 8bb3bfd into main Sep 17, 2024
12 checks passed
@ntruchsess ntruchsess deleted the feature/700-invite branch September 17, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

@evegufy evegufy Awaiting requested review from evegufy

Assignees

@ntruchsess ntruchsess

Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 24.12
Development

Successfully merging this pull request may close these issues.

Invite Service - Delay in displaying application record after company invite
2 participants
@Phil91 @ntruchsess