Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serviceAccount): adjust response for get serviceaccount detail #964

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Sep 2, 2024

Description

  • remove subscriptionId from response

Why

The subscription Id is responded twice, it is already present in the offerData

Issue

Refs: #897

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 added this to the Release 24.12 milestone Sep 6, 2024
Copy link

sonarcloud bot commented Sep 13, 2024

@ntruchsess ntruchsess merged commit 006bb35 into main Sep 16, 2024
11 checks passed
@ntruchsess ntruchsess deleted the bugfix/897-subscription-id branch September 16, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants